Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 83798 - media-libs/svgalib-1.9.19-r3: Changing kernel-mod eclass to linux-info
Summary: media-libs/svgalib-1.9.19-r3: Changing kernel-mod eclass to linux-info
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 74396
  Show dependency tree
 
Reported: 2005-03-02 03:37 UTC by Kalin KOZHUHAROV
Modified: 2005-04-24 00:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
svgalib-1.9.19-r3.ebuild.diff (svgalib-1.9.19-r3.ebuild.diff,1.28 KB, patch)
2005-03-02 03:40 UTC, Kalin KOZHUHAROV
Details | Diff
v0.2 of svgalib-1.9.19-r3.ebuild.diff (svgalib-1.9.19-r3.ebuild.diff,1.30 KB, patch)
2005-03-03 13:15 UTC, Kalin KOZHUHAROV
Details | Diff
v0.3 of svgalib-1.9.19-r3.ebuild.diff (svgalib-1.9.19-r3.ebuild.diff,1.30 KB, patch)
2005-03-12 23:33 UTC, Kalin KOZHUHAROV
Details | Diff
linux-mod conversion (patch,3.07 KB, patch)
2005-03-16 08:48 UTC, Daniel Drake (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalin KOZHUHAROV 2005-03-02 03:37:39 UTC
At the moment svgalib uses kernel-mod eclass which is broken when KBUILD_OUTPUT is used.


Reproducible: Always
Steps to Reproduce:
Comment 1 Kalin KOZHUHAROV 2005-03-02 03:40:27 UTC
Created attachment 52444 [details, diff]
svgalib-1.9.19-r3.ebuild.diff

This patch solves the problem.

Possibly related to this bug (i.e. will be solved if this goes in the tree) are
bug #79666, bug #79859 and bug #82702.
Comment 2 SpanKY gentoo-dev 2005-03-03 08:49:56 UTC
the bugs referenced have nothing to do with KBUILD_OUTPUT

kernel team, what's the status of KBUILD_OUTPUT in ebuilds ?
Comment 3 SpanKY gentoo-dev 2005-03-03 08:50:20 UTC
kernel team, see above please
Comment 4 Kalin KOZHUHAROV 2005-03-03 11:40:40 UTC
bug #7966 : talks about "your kernel source isnt properly setup"
  Or is the kernel-mod wrong?

bug #7859 : unrelated, me - wrong

bug #82702 : suggested solution is commenting out exactly what I changed
  So probably there is if not KBUILD_OUTPUT related, then kernel-mod related bug. 
Comment 5 Kalin KOZHUHAROV 2005-03-03 11:43:31 UTC
Ooops, wrong bug numbers in the last comment, sorry.
Please, ignore my comment #4 completely.

bug #79666 : talks about "your kernel source isnt properly setup"
  Or is the kernel-mod wrong?

bug #79859 : unrelated, me - wrong

bug #82702 : suggested solution is commenting out exactly what I changed
  So probably there is if not KBUILD_OUTPUT related, then kernel-mod related bug. 
Comment 6 Kalin KOZHUHAROV 2005-03-03 13:15:25 UTC
Created attachment 52571 [details, diff]
v0.2 of svgalib-1.9.19-r3.ebuild.diff

Being more precise (according to bug #82702):

if kernel_is gt 2 6 0 && kernel_is lt 2 6 6
Comment 7 John Mylchreest (RETIRED) gentoo-dev 2005-03-06 14:37:24 UTC
linux-info supports KBUILD_OUTPUT as fully as it can.
linux-mod will inherit linux-info and should be used when building kernel modules.
linux-info should be used by any ebuild requiring kernel information.

Hope this answers your q spanky.


Whats the status of this bug now?
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2005-03-12 14:26:18 UTC
Kalin: As svgalib is a kernel module, it should really use linux-mod.eclass
Do you fancy converting the ebuild to use linux-mod?
Comment 9 Kalin KOZHUHAROV 2005-03-12 23:33:28 UTC
Created attachment 53311 [details, diff]
v0.3 of svgalib-1.9.19-r3.ebuild.diff

Substituted linux-info with linux-mod.

As said in comment #7, linux-mod inherits linux-info, so actually I am using
the functions from the inherited linux-info (If only it was OOP!).

New patch tested => works.
Comment 10 Daniel Drake (RETIRED) gentoo-dev 2005-03-16 08:48:53 UTC
Created attachment 53633 [details, diff]
linux-mod conversion

If you want to be a true linux-mod user then you need to use the cleverness
which it provides :)

Mike, is this ok to commit?
Comment 11 Kalin KOZHUHAROV 2005-03-16 20:20:57 UTC
Now we are talking :-)
I wasn't sure exactly how to use the linux-mod eclass, now I see a good example.

Testeg end works for me, excep the following grep warning:

>>> original instance of package unmerged safely.
 * Restarting udev to reread udev rules...                                                                                    [ ok ]
 * Updating module dependencies for 2.6.11-KK1_ss...                                                                          [ ok ]
grep: /var/tmp/portage/svgalib-1.9.19-r3/image//etc/modules.d/*: No such file or directory
 * If you would like to load this module automatically upon boot
 * please type the following as root:
 *     # echo "svgalib_helper" >> /etc/modules.autoload.d/kernel-2.6
 * 
 * When upgrading your kernel you'll need to rebuild the kernel module.
>>> Regenerating /etc/ld.so.cache...

I guess it might be a problem with linux-mod itself?
Comment 12 SpanKY gentoo-dev 2005-04-19 20:24:01 UTC
if that linux-mod stuff works with linux-2.4 too and not just 2.6, then yes it looks good to commit :)
Comment 13 SpanKY gentoo-dev 2005-04-24 00:53:01 UTC
integrated with 1.9.21, thanks all