Bug 83645 – opengl-update --use-old should check for broken symlinks

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Luca Barbato 2005-03-01 01:55:23 UTC]

seems that it fails to update correctly the opengl includes, usually the issue is fixed just calling opengl-update properly.

switch_opengl_implem seems the problem

[Comment 1 Luca Barbato 2005-03-01 02:00:50 UTC]

the problem seems to be in opengl-update --use-old.

there are 2 ways to avoid that:

- make sure that --use-old does refresh symlinks if they are broken (currently does nothing)

- do not use --use-old and just make it refresh the implementation always.

[Comment 2 Donnie Berkholz (RETIRED) 2005-03-01 08:12:45 UTC]

If we don't use --use-old, we switch people's implementations who are using ati or nvidia. So either we should fix --use-old in opengl-update to do as you suggest (IMHO the better solution) or hack around it by saving the current implem at the beginning of xorg, then restoring at the end.

[Comment 3 Luca Barbato 2005-03-02 02:30:01 UTC]

opengl-update "`opengl-update --get-implementation`"

acts nice as workaround.

I'll add that to the ebuild during the evening if nobody is against it

[Comment 4 Donnie Berkholz (RETIRED) 2005-03-02 14:32:42 UTC]

Luca, what's that do when opengl-update has never been run before (i.e., a brand-new installation)?

[Comment 5 Luca Barbato 2005-03-02 14:41:05 UTC]

just a matter to add a condition to the if I think

[Comment 6 Donnie Berkholz (RETIRED) 2005-03-02 15:45:17 UTC]

Go ahead and commit it, as long as it works in that case.

[Comment 7 Luca Barbato 2005-03-03 02:19:22 UTC]

Created attachment 52531 [details, diff]
Minor error fixed

That is the patch I'm going to commit

[Comment 8 Luca Barbato 2005-03-03 02:24:59 UTC]

Comment on attachment 52531 [details, diff]
Minor error fixed

>Index: xorg-x11-6.8.2.ebuild
>===================================================================
>RCS file: /var/cvsroot/gentoo-x86/x11-base/xorg-x11/xorg-x11-6.8.2.ebuild,v
>retrieving revision 1.11
>diff -u -b -B -u -r1.11 xorg-x11-6.8.2.ebuild
>--- xorg-x11-6.8.2.ebuild	26 Feb 2005 00:50:42 -0000	1.11
>+++ xorg-x11-6.8.2.ebuild	3 Mar 2005 10:18:31 -0000
>@@ -1901,10 +1901,11 @@
> 		# Use new opengl-update that will not reset user selected
> 		# OpenGL interface ...
> 		echo
>-		if [ "$(${ROOT}/usr/sbin/opengl-update --get-implementation)" = "xfree" ]; then
>+		local opengl_implem="$(${ROOT}/usr/sbin/opengl-update --get-implementation)"
>+		if [ "${opengl_implem}" = "xfree" -o -z "${opengl_implem}" ]; then
> 			${ROOT}/usr/sbin/opengl-update ${PN}
> 		else
>-			${ROOT}/usr/sbin/opengl-update --use-old ${PN}
>+			${ROOT}/usr/sbin/opengl-update ${opengl_implem}
> 		fi
> }
>

[Comment 9 Donnie Berkholz (RETIRED) 2005-03-03 12:58:27 UTC]

looks good to me

[Comment 10 Luca Barbato 2005-03-03 19:13:24 UTC]

the fix in the current 6.8.2, I'd revbump it asap given we have other fixes available within the week

[Comment 11 Donnie Berkholz (RETIRED) 2005-03-03 22:48:39 UTC]

It's gonna be in the bump with bug #83598.

[Comment 12 Donnie Berkholz (RETIRED) 2005-03-09 17:43:05 UTC]

Should be worked around in 6.8.2-r1 then. Jeremy, can you look at a better fix for this in opengl-update?

[Comment 13 Jeremy Huddleston (RETIRED) 2005-04-26 13:14:36 UTC]

Fixed in cvs's package.masked 2.2.0 (but not neccessarily the one on rsync mirrors yet), thanks.