Bug 83603 – patch for devil-1.6.7 to fix ogre-1.0 bug on amd64

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mark <Line72> Dillavou 2005-02-28 13:40:41 UTC]

This is a patch for devil-1.6.7 so it only links against libpng-1.2 instead of libpng-3.  You also need to apply the libpng patch in bug 83602 for this to work.  This (and the libpng patch) let ogre-1.0 to correctly load png images without crashing.  Please see bug 83602 and bug 83306 for more information

Reproducible: Always
Steps to Reproduce:
1. emerge devil
2. emerge ogre
3. run any ogre app that load png images

Actual Results:  
ogre crashes

Expected Results:  
ogre should load and display the images

this is for amd64 only!  I haven't tested this on x86 or any other archs!

[Comment 1 Mark <Line72> Dillavou 2005-02-28 13:42:38 UTC]

Created attachment 52324 [details]
patch for devil-1.6.7 under amd64 only to link against libpng-1.2 instead of libpng3

[Comment 2 Alex Howells (RETIRED) 2005-02-28 14:05:10 UTC]

Assigned to the correct architecture team.

[Comment 3 Ivan Trombley 2005-03-16 11:53:28 UTC]

Created attachment 53643 [details, diff]
Changes the types that are passed to png_get_IHDR from ILuint to png_uint_32

Using libpng-1.2.8 still doesn't work, this patch fixes DevIL to use the
correct types.

[Comment 4 Ivan Trombley 2005-03-16 11:54:38 UTC]

I added a patch to fix the data types passed to png_get_IHDR from DevIL.

[Comment 5 Mark <Line72> Dillavou 2005-03-16 12:08:03 UTC]

Does this mean libpng no longer needs the extra patches too?  Please see bug #83602 for more info on the libpng patch,

[Comment 6 Ivan Trombley 2005-03-17 23:34:58 UTC]

Changing the typedefs in libpng would require recompiling everything that uses it, otherwise things like Gnome become totally hosed. I think the best fix is to have DevIL use the correct types (as defined in png.h).

[Comment 7 SpanKY 2005-04-01 15:26:58 UTC]

please post an example .c so we can test/debug this w/out screwing with libpng

[Comment 8 Louai Khanji 2005-04-12 14:46:49 UTC]

libpng-1.2.8 works fine for me after applying the patch from comment #3, which I think is the correct fix. Ogre now works fine. Nothing else was patched. This is with devil 1.6.7

[Comment 9 SpanKY 2005-04-12 16:58:05 UTC]

libpng will not be patched, it'll break a ton of apps

[Comment 10 Sebastian Strand 2005-05-18 10:50:19 UTC]

Yes, I finally got Ogre working here with only the patch from comment #3 
applied to devil (and an unmodified libpng-1.2.8). Should be applied, IMO.   
 

[Comment 11 Michael Kedzierski 2005-05-21 02:11:41 UTC]

I agree with comment #10, this patch does work.

[Comment 12 SpanKY 2005-05-21 18:06:30 UTC]

added the 2nd patch to cvs, thanks