Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 835333 - dev-util/pkgdev-0.1.9: wrong copyright year when comitting
Summary: dev-util/pkgdev-0.1.9: wrong copyright year when comitting
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-15 11:20 UTC by Viorel Munteanu
Modified: 2022-03-24 17:04 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Viorel Munteanu gentoo-dev 2022-03-15 11:20:20 UTC
Hi.

I have an ebuild with this line:

# Copyright 2021 Gentoo Authors

`pkgdev commit` changes it to:

# Copyright 2022 Gentoo Authors

while `repoman commit` changes it to:

# Copyright 2021-2022 Gentoo Authors

I think repoman is right.

Thank you!
Comment 1 Mike Gilbert gentoo-dev 2022-03-15 13:21:11 UTC
I don't think it matters much, either way.
Comment 2 Thomas Bracht Laumann Jespersen 2022-03-23 08:46:29 UTC
I tested this, and think at least we can call it "confirmed". It's another matter of it being considered "wrong", I think :-)

Anyhow, I opened a PR to add this behaviour: https://github.com/pkgcore/pkgdev/pull/49

It turned out that the copyright year mangling was actually changed between versions 0.1.8 and 0.1.9 (so it was never released). See [0] and [1].

[0] https://github.com/pkgcore/pkgdev/commit/303e3bde8a1d273b85395541a7f266d7e4f8a6c0
[1] https://github.com/pkgcore/pkgdev/commit/51c0f9a8ba88b776551057f08a1dc0278d4b1eb3
Comment 3 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2022-03-24 17:04:19 UTC
The PR was merged - thank you Thomas Jespersen

https://github.com/pkgcore/pkgdev/commit/59e232009989691e48fe446d8f9e76f0e2cc5e5c