I noticed that there was quite a list of bugs about transcode >=0.6.12 and k3b, especially around k3b requiring transcode-0.6.11. According to these bugs, the main reason is around DVD ripping, and a parameter change to "tccat". The attached patches backport the code that handle the tccat parameter changes from k3b CVS to k3b-0.11.20, and update the ebuild appropriately. Reproducible: Always Steps to Reproduce: 1. emerge transcode > 0.6.11 2. emerge k3b Actual Results: transcode is downgraded to 0.6.11 Expected Results: k3b now uses transcode > 0.6.11 (i.e. 0.6.14 on my system)
Created attachment 52283 [details, diff] Patch to "k3bdvdrippingprocess.cpp" backported from k3b CVS This patch will add the transcode >= 0.6.12 support to k3bdvdrippingprocess.cpp; the patch cleanly compiles on my system, but I have not tested the functionality as I don't rip DVDs.
Created attachment 52284 [details, diff] Patch to ebuild (bumps to -r1 revision)
James, we're reserved to non-critical patches. If you get the patch accepted upstream, I see no problem to add it. ;)
*** Bug 88213 has been marked as a duplicate of this bug. ***
OK, since this obviously bothers more than just myself, I've emailed upstream to see if they'll accept the patch for any future 0.11.xx releases. We'll see....
Patch has been accepted upstream. I don't know when the point release will be, however, so perhaps apply my patches to the ebuild in the interim?? -----Original Message----- From: Sebastian Trueg [mailto:trueg@k3b.org] Sent: Friday, 8 April 2005 20:06 To: Roberts-Thomson, James Subject: Re: Small patch for k3b 0.11.x well, ok, I will apply it then. It surely won't make things worse. ;) thanks.
<<< k3b-0.11.23-r1.ebuild Thanks James. Got your credits in exchange. ;)
Very sorry, but I've just been told that the patch is incomplete; and that there is another check for versions >= 0.6.12 that was missed; I'll reroll the patch shortly.
Seems to be fixed with k3b-0.11.23-r1
Created attachment 56314 [details, diff] Patch to "kk3bdvdrippingprocess.cpp", which actually works. Regarding Comment #9, I think you'll find it will compile, but when you try a rip it will fail with a specific comment about the version of transcode being incorrect. This newer patch will fix that.
My fault. And a warning is not a bad idea, too. ;)
> And a warning is not a bad idea, too. ;) Carlo: about this warning you added (that dvd ripping is not possible with transcode >= 0.6.12), isn't the patch exactly made so that dvd ripping _is possible_ with transcode >= 0.6.12?
Yes, you are right. I had somehow in mind that ripping would work now, but transcoding not. Will fix that and mark .23 stable when Bug 91061 is resolved.
