Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 83480 - media-tv/mythtv-0.17 ebuild fails to properly disable Xv support
Summary: media-tv/mythtv-0.17 ebuild fails to properly disable Xv support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Television related Applications in Gentoo's Portage
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-02-27 10:36 UTC by John Myers
Modified: 2005-05-12 01:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to ebuild to successfully disable xv (mythtv_0.17-r1_disable_xv.patch,525 bytes, patch)
2005-04-12 10:56 UTC, Simon Koch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Myers 2005-02-27 10:36:20 UTC
The sed command the ebuild uses to disable Xv when the xv useflag is not set is insufficient.

Reproducible: Always
Steps to Reproduce:
1. Build xorg-x11 with USE="-xv"
2. Build mythtv with USE="-xv"
Actual Results:  
emerge of mythtv dies missing -lXv

Expected Results:  
emerge of mythtv succeeds not needing -lXv

The ebuild contains the following snippet:

==(snip)===
        if ! use xv ; then
                sed -e 's:CONFIG += using_xv:#CONFIG += using_xv:' \
                        -e 's:EXTRA_LIBS += -L/usr/X11R6/lib:#EXTRA_LIBS +=
-L/usr/X11R6/lib:' \
                        -i 'settings.pro' || die "disable xv failed"
        fi
===(/snip)===

However, this is insufficient. after doing this, settings.pro still contains
this snippet:

===(snip)===
# Default Xv support
#CONFIG += using_xv
EXTRA_LIBS += $$LOCAL_LIBDIR_X11 -lXinerama -lXv -lX11 -lXext -lXxf86vm
===(/snip)===

I have commented out that EXTRA_LIBS line. I am still rebuilding mythtv right
now. If it works, I will prepare a patch.
Comment 1 Simon Koch 2005-04-12 10:56:09 UTC
Created attachment 56106 [details, diff]
patch to ebuild to successfully disable xv

I don't remember how I worked around this in 0.17, but for 0.17-r1 this change
to the ebuild worked for me.  Commenting out the whole EXTRA_LIBS line caused
it to fail looking for Xinerama, so I just took out the "-lXv" part.
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2005-05-12 01:03:03 UTC
Fixed in 0.18.