Bug 834240 – net-news/sfeed: Missing USE flags and unneeded dependency

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description NRK 2022-02-27 08:50:28 UTC]

Hi,

The sfeed package has existed in guru[0] for while and was recently added to
gentoo. However the gentoo ebuild doesn't have theme support via USE flags which
the guru package does.

The gentoo package also unnecessarily depends on `xclip` (can be changed via
$SFEED_YANKER) and `lynx` (can be changed via $SFEED_HTMLCONV) which are
optional run-time dependency and should be in `opt-feature` instead.

I'm not sure what the dependency on xdg-utils is for, I don't have xdg-utils on
my system and have been using sfeed + sfeed_curses fine for months now. So I
suspect it probably something that should be opt-feature as well.

[0]: https://gitweb.gentoo.org/repo/proj/guru.git/tree/net-news/sfeed/sfeed-1.2-r1.ebuild

[Comment 1 Sam James 2022-02-27 19:49:27 UTC]

Also:
- Hard dependency on sys-libs/glibc is suspect (it's not a binary package), means it can't work on musl, or some prefixes...
- Assumed/assumes tinfo. The guru ebuild uses the correct method (pkg-config), but should use tc-getPKG_CONFIG though.

[Comment 2 NRK 2022-02-27 21:25:08 UTC]

The Sfeed README[0] states that sfeed has been tested to work with musl. It also says that curl is also an optional depedancy which can be replaced by wget/hurl etc.

[0]: https://git.codemadness.org/sfeed/file/README.html

[Comment 3 Sam James 2022-03-09 15:16:23 UTC]

commit 32b54eeb68f1d3e823e7d02677e0931cc383a8b3 (HEAD -> master, origin/master, origin/HEAD)
Author: Nickolas Raymond Kaczynski <[e-mail]>
Date:   Wed Mar 9 12:33:23 2022 +0600

    net-news/sfeed: add myself as proxy maint

    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Nickolas Raymond Kaczynski <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/24420
    Signed-off-by: Sam James <[e-mail]>

commit 03b4fbc065487ffc7447f1334dce20bb0f94a4b1
Author: Nickolas Raymond Kaczynski <[e-mail]>
Date:   Mon Mar 7 21:16:22 2022 +0600

    net-news/sfeed: bump to 1.3 and improvements

    * removes unneeded dependencies, add them to optfeature
    * adds theme support via USE flag and savedconfig
    * downgrade to EAPI 7 (8 doesn't support savedconfig)
    * don't assume -ltinfo, use virtual/pkgconfig instead
    * fix document location
    * fix some quote and style issues

    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Nickolas Raymond Kaczynski <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>