Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833603 - media-gfx/brscan5: new package
Summary: media-gfx/brscan5: new package
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2022-02-18 11:20 UTC by Tobias Leupold
Modified: 2024-05-02 07:52 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Apdapted ebuild from github.com/qix67/gentoo-overlay (brscan5-1.2.9_p0.ebuild,2.08 KB, text/plain)
2022-02-18 11:20 UTC, Tobias Leupold
Details
The brother5.conf file from files/ installed by the ebuild (brother5.conf,9 bytes, text/plain)
2022-02-18 11:21 UTC, Tobias Leupold
Details
Updated ebuild for eapi 8 and brscan5-1.2.13-0 (brscan5-1.2.13_p0.ebuild,2.08 KB, text/plain)
2023-09-01 13:33 UTC, Tobias Leupold
Details
git patch for the build (0001-ebuild-for-brscan5-1.2.13_p0.patch,2.95 KB, patch)
2023-11-10 13:56 UTC, Tobias Leupold
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2022-02-18 11:20:11 UTC
Created attachment 765376 [details]
Apdapted ebuild from github.com/qix67/gentoo-overlay

We currently only have media-gfx/brscan4 in portage. Newer Brother scanners (in my case a DS-640) need the currently available brscan5 driver to work properly.

I took the brscan5 ebuild from https://github.com/qix67/gentoo-overlay (the only one I could find) and adapted it to work with the currently available version 1.2.9-0 of the brscan5 driver. It works without a problem. I think the ebuild would need some refactoring though, as it e.g. does not set the correct source URI for the x86 version and probably also has some other flaws.

However, it would be nice if portage supported this brscan generation. Thanks in advance for adding official support for brscan5!
Comment 1 Tobias Leupold 2022-02-18 11:21:13 UTC
Created attachment 765377 [details]
The brother5.conf file from files/ installed by the ebuild
Comment 2 Jonas Stein gentoo-dev 2022-02-19 23:25:06 UTC
I do not understand, if this is a version bump of brscan4, or something new.

HOMEPAGE="http://welcome.solutions.brother.com/bsc/public_s/id/linux/en/index.html" is 404

Should we use 
https://support.brother.com  
?
Comment 3 Tobias Leupold 2022-02-20 07:35:36 UTC
To reach the download page for the brscan driver, you actually have to search for some product, select "Linux", possibly "English", and then you see it. I think there's no direct link we could add, so https://support.brother.com/ is the starting point to begin.

I'm not sure if brscan5 is something new either ... but I'm running an old manual installation of brscan3 on another machine (to access the scanner part of a Brother MFC printer/scanner/fax). So I could try out if that also works with brscan5.

If the newer brscan versions support everything the older ones did, I think we should consider to call it "brscan" and move the obvious major version to where it belongs, no?

Maybe some other Brother user can also check this out? I don't think we'll get information from Brother themselves ...

Apart from that:

The ebuild says:
DESCRIPTION="SANE driver for Brother DS-series scanners (brscan5)"

Actually, brscan also supports e.g. the scanners built into the MFC multifunction devices. So possibly, the "Brother scanner driver" we currently have in the tree is more applicable.

Also, the SRC_URI is most probably a generated one that emerged whilst searching downloads for a specific device. But IIRC, one has to download the package manually anyway (and as said, the x86 version is not present).

Also, the current tree ebuild says LICENSE="Brother" whereas the attached one says LICENSE="Brother-EULA" ...

As said, the thing works but definitely needs some love ;-)
Comment 4 Tobias Leupold 2022-02-20 07:41:54 UTC
In the brother-overlay ( https://github.com/gentoo-mirror/brother-overlay ), they have distinct ebuilds for the different brscan versions:

media-gfx/brother-scan2-bin
media-gfx/brother-scan3-bin
media-gfx/brother-scan4-bin
(no ebuild for version 5 yet)

Maybe, these should actually be added to the main portage tree? At least, I think that the people maintaining the Brother overlay will know what's up with those, and they will have a reason to keep different versions.
Comment 5 Ulrich Müller gentoo-dev 2022-02-20 08:59:51 UTC
All newer (since 2014 at least) scanners or multi-function devices from Brother should support driverless scanning over the network with avahi/zeroconf. Therefore these scanner drivers are pretty much legacy; they are only needed for older devices, or if you connect the scanner via USB.

Generally Brother recommends a specific driver package like brscan3 or brscan4 for your device, so it would make little sense to combine these different drivers in one package.

Reassigning to maintainer-wanted, because I don't have any device to test this. (And see above, if I had then I'd use it driverless.)
Comment 6 Tobias Leupold 2022-02-20 09:13:47 UTC
> And see above, if I had then I'd use it driverless.

... unless you have an USB-only scanner, like the DS-640 ;-)
Comment 7 Tobias Leupold 2023-09-01 13:33:33 UTC
Created attachment 869129 [details]
Updated ebuild for eapi 8 and brscan5-1.2.13-0
Comment 8 Tobias Leupold 2023-11-10 10:27:12 UTC
(In reply to Ulrich Müller from comment #5)

Just to point this out once again:

> All newer (since 2014 at least) scanners or multi-function devices from
> Brother should support driverless scanning over the network with
> avahi/zeroconf.

Of course, we should use driverless scanning for multi-function devices. But this is not about those, but pure scanners that don't connect to the LAN and are USB-only.

> Therefore these scanner drivers are pretty much legacy; they
> are only needed for older devices, or if you connect the scanner via USB.

... and for those exact devices, in my case a Brother DS-640 mobile document scanner, those drivers are certainly not "legacy" but simply the only way to use them at all.
Comment 9 Ulrich Müller gentoo-dev 2023-11-10 13:14:37 UTC
(In reply to Tobias Leupold from comment #7)
> Created attachment 869129 [details]
> Updated ebuild for eapi 8 and brscan5-1.2.13-0

Can you provide a copyright signoff please? Either by committing the new package to git and attaching the file obtained by "git format-patch" to this bug (much preferred), or by posting the Signed-off-by line as a comment.
https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

Also, would you volunteer as a proxied maintainer for this package?
Comment 10 Tobias Leupold 2023-11-10 13:56:00 UTC
Created attachment 874466 [details, diff]
git patch for the build

Well, as I'm using this on a regular basis, I can as well proxy-maintain it; at least I can try to do so (as this seems to be a quite complicated ebuild ...).

Here's the signed-off git format-patch output.
Comment 11 Ulrich Müller gentoo-dev 2023-11-10 14:53:40 UTC
(In reply to Tobias Leupold from comment #10)
> Created attachment 874466 [details, diff] [details, diff]
> git patch for the build
> 
> Well, as I'm using this on a regular basis, I can as well proxy-maintain it;
> at least I can try to do so (as this seems to be a quite complicated ebuild
> ...).
> 
> Here's the signed-off git format-patch output.

Thank you. The ebuild should be in the media-gfx/brscan5/ package directory, not at top level of the repository. Also, could you add a metadata.xml for the package? (grep for proxy-maint in other metadata.xml files if you need an example.)
Comment 12 Suvi Adams 2024-04-29 18:52:13 UTC
I had to pull this into my local overlay to get a borrowed USB-only scanner working in a pinch. (brscan4 resulted in pages only being half-scanned, but brscan5 resolved the issues. It's entirely likely that this was user error.)

Just as a heads-up: the ebuild uses rpm_unpack to extract the blob from Brother, so I had to modify it to have app-arch/rpm listed as a BDEPEND.
Comment 13 Tobias Leupold 2024-04-29 19:06:08 UTC
I'll try to update it ...
Comment 14 Ulrich Müller gentoo-dev 2024-04-29 19:43:07 UTC
(In reply to Suvi Adams from comment #12)
> Just as a heads-up: the ebuild uses rpm_unpack to extract the blob from
> Brother, so I had to modify it to have app-arch/rpm listed as a BDEPEND.

rpm_unpack() uses rpm2tar from app-arch/rpm2targz (which is added to BDEPEND by the eclass), so not sure why you would need app-arch/rpm?
Comment 15 Suvi Adams 2024-04-30 15:35:50 UTC
(In reply to Ulrich Müller from comment #14)
> (In reply to Suvi Adams from comment #12)
> > Just as a heads-up: the ebuild uses rpm_unpack to extract the blob from
> > Brother, so I had to modify it to have app-arch/rpm listed as a BDEPEND.
> 
> rpm_unpack() uses rpm2tar from app-arch/rpm2targz (which is added to BDEPEND
> by the eclass), so not sure why you would need app-arch/rpm?

Oh shoot, now I feel rather silly!

I can confirm that my previous comment was completely incorrect. I forgot to put  brother5.conf into files/, and somehow completely failed to realize that I'd not attempted a rebuild between fixing that and adding app-arch/rpm into the BDEPEND.

I'll do my best to learn from this, but sorry to waste everyone's time!
Comment 16 Tobias Leupold 2024-05-02 07:52:30 UTC
You're welcome :-) Thanks for confirming the raison d'être of this ebuild ;-)