Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833420 - dev-libs/rapidjson missing JSON license for tests
Summary: dev-libs/rapidjson missing JSON license for tests
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-15 15:15 UTC by Anna Vyalkova
Modified: 2022-07-11 12:38 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Vyalkova 2022-02-15 15:15:52 UTC
https://raw.githubusercontent.com/Tencent/rapidjson/master/license.txt

JSON license is considered non-free.

Debian removes bin/jsonchecker directory and patches it out in tests:
https://packages.debian.org/sid/rapidjson-dev
Comment 1 Ulrich Müller gentoo-dev 2022-02-17 21:09:19 UTC
If the JSON license applies only to the test suite but not to any of the installed files, then it is not part of the "corresponding source". By our current policy such files need not be listed in the LICENSES variable.

Policy reference:
https://devmanual.gentoo.org/general-concepts/licenses/index.html
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-17 21:12:04 UTC
(In reply to Ulrich Müller from comment #1)
> If the JSON license applies only to the test suite but not to any of the
> installed files, then it is not part of the "corresponding source". By our
> current policy such files need not be listed in the LICENSES variable.
> 
> Policy reference:
> https://devmanual.gentoo.org/general-concepts/licenses/index.html

I can understand this but I think it may be problematic if I don't want to arch test packages with non-free test data or similar. But I can understand that LICENSE doesn't have a way of distinguishing the runtime requirement when merged with tests enabled vs the point of running tests.
Comment 3 Ulrich Müller gentoo-dev 2022-02-17 21:36:42 UTC
(In reply to Sam James from comment #2)
> I can understand this but I think it may be problematic if I don't want to
> arch test packages with non-free test data or similar.

It is merely a usage restriction on top of a MIT license. Arguably, it isn't even enforceable: Copyright is about distribution, not about usage, and you have no contract with the copyright holder that could impose usage restrictions.

So I don't think that we have any problem here (but IANAL).

> But I can understand that LICENSE doesn't have a way of distinguishing the
> runtime requirement when merged with tests enabled vs the point of running
> tests.

Yes, certainly LICENSE="MIT test? ( JSON )" would be wrong, because the installed image is the same in both cases. It's even more obvious if you think of it in terms of a binary package produced either way.
Comment 4 Craig Andrews gentoo-dev 2022-07-11 12:38:12 UTC
Based on comment 3, I believe this issue should be closed.

Please reopen if there's disagreement.

Thank you!