The randomize patch included in the xmms ebuild dumps core on solaris. Reproducible: Always Steps to Reproduce: 1.emege xmms 2. xmm & 3.sort->randomize Actual Results: core dump results Expected Results: It should randomize the list. The current randomize patch makes xmms core dump on solaris because random() returns a number between 0 & 2**31-1 while on linux it returns a number between 0 & RAND_MAX. And the RAND_MAX on linux is 2**31-1 while on solaris it is 32767. The update patch is attached to the bug report: http://bugs.gentoo.org/show_bug.cgi?id=24137 This is more like a place holder because nobody replies to FIXED bugs and I can't reopen it as I am not the owner.
Sorry, we don't have a solaris port or a solaris team, and this issue doesn't affect any of our current ports.
luckily I can re-open this one...:) I have provided an updated patch which works on all current ports and solaris. Its just about replacing a patch with an updated patch. The updated is guaranteed not to break any existing ports because its driven by pre-processor macros.
Is there any update on this bug? The patch works for BOTH linux and solaris.
If there will ever be a Gentoo/OpenSolaris port this is going to be applied by the porters. Closing in the mean time.
how can you close a bug which is not fixed. if the patch breaks anything, tell me about it. If it hurts anyone, please tell me about it. other than the religious wars, is there any technical reason for not including this patch? talk technical if you can. don't close the bug without logic. this patch is a replacement for the existing patch, all you have to do it to put it there. there are people out there who love portage and gentoo, and want to spread it far and wide. And you just discourage them by not accepting TRIVIAL patches like this one. what a shame!
.
the proposed patch kind of sucks ... if you can post one that is clean of define(sun) checks we'll review it again
what's wrong with defined(sun) check?
Again. Please note that a) there's no solaris port of gentoo, so solaris-fixing patches are not needed or prioritized; b) there's no solaris arch team, so nobody can ensure that the patch is fine, or who can maintain it, support it and so on; c) the current patch works for gentoo's target, changing it just for the sake of an unsupported os while there's no plan on changing this If and when a Gentoo Solaris port will be official and there will be an arch team supporting it, this patch is going on portage. *Please* don't reopen this bug.
