Bug 833011 – media-sound/grip : Display rendering hides the 'Rip' column (may be specific to high-res displays)

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Phil Stracchino (Unix Ronin) 2022-02-09 21:45:55 UTC]

Created attachment 764724 [details, diff]
Patch to fix the partially-hidden 'Rip' column in the Grip display

Disclaimer:  THIS MAY BE DISPLAY RESOLUTION SPECIFIC.

At least on a 4K display, widget widths are calculated incorrectly when the CD ripping interface is rendered, resulting in most of the Rip column being hidden.

I finally got around to digging into this, and the solution is ludicrously simple.  It is a one-line fix to cdplay.c.

Patch will be attached in a moment.

This patch works fine just dropped into /etc/portage/patches/media-sound/grip/grip-rip-width.patch.

[Comment 1 Jonas Stein 2022-02-09 22:00:19 UTC]

Thank you for the patch. Please report it upstream (with screenshots before and after) and link the ticket here.
If the patch fixes a problem, it should be merged upstream.

https://sourceforge.net/p/grip/bugs/

[Comment 2 Phil Stracchino (Unix Ronin) 2022-02-09 22:32:41 UTC]

(In reply to Jonas Stein from comment #1)
> Thank you for the patch. Please report it upstream (with screenshots before
> and after) and link the ticket here.
> If the patch fixes a problem, it should be merged upstream.
> 
> https://sourceforge.net/p/grip/bugs/

I just found my previous upstream ticket and posted the patch there as well.

https://sourceforge.net/p/grip/bugs/404/

[Comment 3 Jonas Stein 2022-02-09 22:52:42 UTC]

Created attachment 764733 [details]
grip_screenshot_001.png

Does the patch address the glitch we see in grip_screenshot_001.png?

[Comment 4 Phil Stracchino (Unix Ronin) 2022-02-09 22:58:47 UTC]

(In reply to Jonas Stein from comment #3)
> Created attachment 764733 [details]
> grip_screenshot_001.png
> 
> Does the patch address the glitch we see in grip_screenshot_001.png?

No, I have never personally seen that one happen.  I can say that a LOT of interface bugs were fixed in grip-4.0.0.

I'll need to revert it to get a screenshot of the 'before' condition.