Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 83227 - metabar-0.4.ebuild (new package)
Summary: metabar-0.4.ebuild (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Normal enhancement
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2005-02-24 13:17 UTC by Gleb Litvjak
Modified: 2005-04-08 08:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The ebuild (metabar-0.4.ebuild,945 bytes, text/plain)
2005-02-24 13:26 UTC, Gleb Litvjak
Details
metabar-0.4-r1.ebuild (metabar-0.4-r1.ebuild,1.39 KB, text/plain)
2005-02-25 05:22 UTC, Gleb Litvjak
Details
metabar-0.4a.ebuild (metabar-0.4a.ebuild,768 bytes, text/plain)
2005-02-25 23:34 UTC, Gleb Litvjak
Details
metabar-0.4a.ebuild (metabar-0.4a.ebuild,572 bytes, text/plain)
2005-02-26 01:52 UTC, Dennis Nienhüser (RETIRED)
Details
metabar-0.5.ebuild (metabar-0.5.ebuild,572 bytes, text/plain)
2005-03-15 05:40 UTC, Genady Okrain
Details
metabar-0.6.ebuild (metabar-0.6.ebuild,572 bytes, text/plain)
2005-03-26 20:35 UTC, Heath H Holcomb
Details
metabar-0.6.ebuild (metabar-0.6.ebuild,645 bytes, text/plain)
2005-03-27 00:51 UTC, Genady Okrain
Details
metabar-0.6-fix.patch (metabar-0.6-fix.patch,385 bytes, text/plain)
2005-03-27 00:53 UTC, Genady Okrain
Details
Metabar-0.7.ebuild (metabar-0.7.ebuild,579 bytes, text/plain)
2005-04-04 08:43 UTC, Gleb Litvjak
Details
metabar-kde_export.patch (metabar-kde_export.patch,851 bytes, patch)
2005-04-08 06:31 UTC, Przemyslaw Maciag (RETIRED)
Details | Diff
metabar-kde33-backport.patch (metabar-kde33-backport.patch,684 bytes, patch)
2005-04-08 06:32 UTC, Przemyslaw Maciag (RETIRED)
Details | Diff
metabar-desktop_file.patch (metabar-desktop_file.patch,1.07 KB, patch)
2005-04-08 06:32 UTC, Przemyslaw Maciag (RETIRED)
Details | Diff
metabar-noarts.patch (metabar-noarts.patch,8.44 KB, patch)
2005-04-08 07:23 UTC, Przemyslaw Maciag (RETIRED)
Details | Diff
metabar-0.7-r1.ebuild (metabar-0.7-r1.ebuild,884 bytes, text/plain)
2005-04-08 07:26 UTC, Przemyslaw Maciag (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Litvjak 2005-02-24 13:17:37 UTC
It is an ebuild for metabar (http://www.kde-look.org/content/show.php?content=21168) - a sidebar plugin for KDE wit functions like preview, file info and others. It depends on kdebase 3.2 or newer.

I suggest kde-misc/metabar
Comment 1 Gleb Litvjak 2005-02-24 13:26:29 UTC
Created attachment 52064 [details]
The ebuild
Comment 2 Gleb Litvjak 2005-02-25 05:22:45 UTC
Created attachment 52116 [details]
metabar-0.4-r1.ebuild

Updated the ebuild:
-fixed the homepage link
-the file "metabar_add.desktop" is not copied, but symlinked
-when metabar is unmerged, the symlink to metabar_add.desktop is removed if the
target file does not exist
Comment 3 Benjamin Schindler (RETIRED) gentoo-dev 2005-02-25 07:19:43 UTC
First, your ebuild doesn't honor the arts-useflag. I think the kde-eclass provides a lot of functionality already, so check that out. 
And second, it won't compile even if you disable arts (I added --without-arts and tried) - I get a compilation error, about kartserver.h: file not found. This is a metabar issue, not an ebuild issue though
Comment 4 Dennis Nienhüser (RETIRED) gentoo-dev 2005-02-25 09:11:55 UTC
Why do you inherit kde and then don't use it? I think src_compile and src_install can both be removed entirely.
Comment 5 Gleb Litvjak 2005-02-25 11:00:39 UTC
Sorry, my bad. I should remove "inherit kde" and add arts as a dependency. This is my first ebuild (I copied it from another, that's why it is a bit buggy). I will correct it and submit the corrected variant when I get home.
Comment 6 Simone Gotti (RETIRED) gentoo-dev 2005-02-25 11:27:26 UTC
You shouldn't remove "inherit kde", you should remove all the other ebuild functions.

For the symlink, does it worked with the SANDBOX feature? I don't think so, and it's defenitely wrong. The right thing to do is to simply fix the ebuild Makefiles (just change Makefile.am and Makefile.in) to make them install the file in the right place.
Comment 7 Gleb Litvjak 2005-02-25 23:34:33 UTC
Created attachment 52164 [details]
metabar-0.4a.ebuild

Well, the author of metabar released a new version with the location of
metabar_add.desktop fixed, so I could make an ebuild w/o that dirty hack with
symlinks. 

Other fixes:
-"inherit kde" replaced with "inherit kde-functions"
-added arts as a dependency
-removed ~amd64 (haven't tested it on amd64)

src_compile() and src_install() functions could not be removed because the
ebuild would install to /usr, not /usr/kde/kdeversion without them.
Comment 8 Gleb Litvjak 2005-02-25 23:35:43 UTC
BTW, the symlink *did* work with SANDBOX feature.
Comment 9 Dennis Nienhüser (RETIRED) gentoo-dev 2005-02-26 01:52:17 UTC
Created attachment 52167 [details]
metabar-0.4a.ebuild

Cleaned up ebuild (inherit kde, removed RESTRICT, removed src_compile etc)

The symlink in the first version did work because afaik pkg_postinst isn't
sandbox protected, which makes it an even more ugly hack. Notice there is dosym
(man 5 ebuild) for creating symlinks.
Comment 10 Simone Gotti (RETIRED) gentoo-dev 2005-02-26 03:06:38 UTC
All the external programs (not in kde-base category) should go in /usr and not in `kde-config --prefix`.
Comment 11 Gleb Litvjak 2005-02-26 03:22:04 UTC
2 Simone Gotti:
Ok, didn't know that, thanks for the info. I thought it should go to the dir kde is installed, as it integrates into konqueror. The cleaned version by Dennis Nienh
Comment 12 Gleb Litvjak 2005-02-26 03:22:04 UTC
2 Simone Gotti:
Ok, didn't know that, thanks for the info. I thought it should go to the dir kde is installed, as it integrates into konqueror. The cleaned version by Dennis Nienhüser installs metabar into /usr, so the issue is fixed.

2 Dennis Nienhüser:
Thanks for cleaning the ebuild - it is now much better.
Comment 13 Bart Verwilst 2005-02-26 03:54:52 UTC
Tested the ebuild on amd64, works like a charm btw ;)
Comment 14 Gleb Litvjak 2005-03-11 00:52:24 UTC
The metabar 0.5 is out. The ebuild can be just renamed to metabar-0.5.ebuild.
Comment 15 Genady Okrain 2005-03-15 05:40:42 UTC
Created attachment 53515 [details]
metabar-0.5.ebuild
Comment 16 Heath H Holcomb 2005-03-26 20:35:52 UTC
Created attachment 54567 [details]
metabar-0.6.ebuild
Comment 17 Gleb Litvjak 2005-03-26 21:51:25 UTC
metabar-0.6 fails to compile against kde-3.4.0

There is a fix, so we should wait until it's integrated into the main source tree (or someone should make a patch).
Comment 18 Genady Okrain 2005-03-27 00:51:04 UTC
Created attachment 54575 [details]
metabar-0.6.ebuild
Comment 19 Genady Okrain 2005-03-27 00:53:02 UTC
Created attachment 54576 [details]
metabar-0.6-fix.patch
Comment 20 Gleb Litvjak 2005-04-04 08:43:48 UTC
Created attachment 55278 [details]
Metabar-0.7.ebuild
Comment 21 Gregorio Guidi (RETIRED) gentoo-dev 2005-04-05 11:02:56 UTC
In portage. Thanks.
Comment 22 Gregorio Guidi (RETIRED) gentoo-dev 2005-04-05 15:25:06 UTC
Mmm... metabar uses a method from kmimetype.h which is only present in kde-3.4, so I raised the dependency to 3.4 in the ebuild.
Comment 23 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 06:29:10 UTC
problems with metabar:
- it's fully depends on arts, without arts compilation will failed; I'm made a patch for this and checking it now [it works with -arts, but we're checking +arts comiplation)
- for kde-3.3.x there is a patch on kde-apps.org [I added to new ebuild version]
- on kde-apps.org there is one more fix for metabar (both can be find here http://linux01.gwdg.de/~pbleser/rpm-navigation.php?cat=Utilities/metabar)
- also I made patch with polish translation for desktop files (well... it's not a problem, but I like to have everything in my own language ;-) )

If everything will work ok with +arts, I'll submit everything here.

Regards,
Przemek
Comment 24 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 06:31:55 UTC
Created attachment 55667 [details, diff]
metabar-kde_export.patch

from http://linux01.gwdg.de/~pbleser/rpm-navigation.php?cat=Utilities/metabar
Comment 25 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 06:32:26 UTC
Created attachment 55668 [details, diff]
metabar-kde33-backport.patch

kde-3.3.x compilation fix from
http://linux01.gwdg.de/~pbleser/rpm-navigation.php?cat=Utilities/metabar
Comment 26 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 06:32:49 UTC
Created attachment 55669 [details, diff]
metabar-desktop_file.patch

polish translations for desktop files
Comment 27 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 07:23:37 UTC
Created attachment 55672 [details, diff]
metabar-noarts.patch

I haven't tested a patch with arts in USE flags, vause I haven't build my KDE
with it. In ebuild I provided here, patch is being applied only if there is no
arts in USE, but I think it should be ok even if it is there.
Comment 28 Przemyslaw Maciag (RETIRED) gentoo-dev 2005-04-08 07:26:20 UTC
Created attachment 55673 [details]
metabar-0.7-r1.ebuild

ebuild that corespondes to patches I submit here. Ebuild has another local USE
flag - "kde33"... it's bad. IMHO - ebuild should check ther version of
installed KDE and after checking, if it something below 3.4 version, it should
apply metabar-kde33-backport.patch.

checking may be done, by sothing like:
kde-config -v | grep KDE | awk '{print $2}'

Hope you find it useful.

Regards,
Przemek
Comment 29 Gregorio Guidi (RETIRED) gentoo-dev 2005-04-08 08:34:50 UTC
Please do not write on closed bugs, it's better to open a new one instead.

Anyway, all these patches are not Gentoo-specific, so it seems more reasonable to send them directly to the author to have them included in the next version...