Bug 83168 – rosegarden 1.0 compilation crashes when dssi not present

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pierre-Yves AILLET 2005-02-24 03:40:47 UTC]

The problem is in the file gui/audiopluginoscgui.cpp where dssi.h is included even if HAVE_DSSI isn't set.
This issue is resolved in the rosegarden cvs.

Reproducible: Always
Steps to Reproduce:
1.don't have dssi present
2.ACCEPT_KEYWORDS="~x86" emerge rosegarden
3.




Portage 2.0.51-r15 (default-linux/x86/2004.3, gcc-3.3.4,
glibc-2.3.4.20050125-r0, 2.6.10-gentoo-r7 i686)
=================================================================
System uname: 2.6.10-gentoo-r7 i686 AMD Duron(tm)
Gentoo Base System version 1.6.9
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Feb 18 2005, 13:08:19)]
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled]
dev-lang/python:     2.3.5
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.8.5-r3, 1.7.9-r1, 1.5, 1.9.4, 1.4_p6, 1.6.3
sys-devel/binutils:  2.15.92.0.2-r1, 2.15.92.0.2-r2
sys-devel/libtool:   1.5.10-r5
virtual/os-headers:  2.4.22-r1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=athlon -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env
/usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon -fomit-frame-pointer -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distcc distlocks sandbox sfperms"
GENTOO_MIRRORS="http://mirror.gentoo.no/ http://ds.thn.htu.se/linux/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://192.168.0.2/gentoo-portage"
USE="x86 3dnow 3dnowex X a52 acpi acpi4linux aim alsa audiofile avi
bash-completion berkdb bitmap-fonts bmp bootsplash caps cdparanoia codecs crypt
cscope css cups curl devfs26 divx4linux emboss encode esd f77 faad fam fame
ffmpeg fftw flac flash fluidsynth font-server fpx ftp gdbm gif gnome gpm
gstreamer gtk gtk2 guile icq imagemagick imlib ipv6 jack jack-tmpfs java jpeg
kde ladspa libcaca libg++ libwww mad mikmod mmx mmx2 motif mozilla moznocompose
moznoirc moznomail moznoxft mp3 mpeg mpeg4 mplayer msn ncurses nls oggvorbis
openal opengl openntpd openssh oss pam pdf pdflib perl png portaudio python qt
quicktime readline samba sdl slang soundtouch sox spell ssl svga tcltk tcpd
tetex tga tiff timidity truetype truetype-fonts type1-fonts usb vim-with-x vnc
wmf xine xml2 xmms xpm xscreensaver xv zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS

[Comment 1 Pierre-Yves AILLET 2005-02-24 03:44:18 UTC]

here is the diff from the CVS

===================================================================
RCS file: /cvsroot/rosegarden/gui/audiopluginoscgui.cpp,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- rosegarden/gui/audiopluginoscgui.cpp	2005/02/08 14:55:50	1.32
+++ rosegarden/gui/audiopluginoscgui.cpp	2005/02/17 09:50:51	1.33
@@ -24,9 +24,12 @@
 #ifdef HAVE_LIBLO
 
 #include <lo/lo.h>
-#include <dssi.h>
 #include <iostream>
 
+#ifdef HAVE_DSSI
+#include <dssi.h>
+#endif
+
 #include "PluginIdentifier.h"
 #include "AudioPluginInstance.h"
 #include "MappedCommon.h"

[Comment 2 Carsten Lohrke (RETIRED) 2005-02-24 05:35:08 UTC]

btw. dssi is requested: Bug 83082

[Comment 3 Pierre-Yves AILLET 2005-02-24 06:03:46 UTC]

I think there should be dssi USE for rosegarden and dssi included in portage in the future.

[Comment 4 Jan Brinkmann (RETIRED) 2005-03-09 13:49:58 UTC]

fixed in cvs, thanks.