Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 83055 - php5-sapi.eclass broken by fix to bug 80574
Summary: php5-sapi.eclass broken by fix to bug 80574
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High major (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-23 04:19 UTC by Dani Church
Modified: 2005-03-15 09:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix to eclass/php5-sapi.eclas (php5-sapi.eclass-sharedext.patch,5.63 KB, patch)
2005-02-23 04:20 UTC, Dani Church
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Church 2005-02-23 04:19:18 UTC
In the fix to bug 80574, conversion to 'sharedext' was incomplete; several changes within php5-sapi.eclass were required, as per the attached patch.  php5-sapi_src_install() continued to use 'shared' as its test for whether to install modules, and that broke ebuilds with USE="shared -sharedext" because it tried to install modules ('shared') that weren't built ('-sharedext').  Assumably the converse would also be true, that for a USE="-shared sharedext" ebuild it would build the modules but not install them.

This brings up another point-- specifically, that if the 'sharedext' use flag is given but no specific modules are selected, the ebuild will fail.  This case may be trivial enough to ignore, though.

The patch also updates IUSE to remove the 'shared' flag and updates the calls to enable_extension_{disable,without}, since those functions now actually use the third argument.

Reproducible: Always
Steps to Reproduce:
Comment 1 Dani Church 2005-02-23 04:20:47 UTC
Created attachment 51934 [details, diff]
Fix to eclass/php5-sapi.eclas

(as mentioned in bug description)
Comment 2 Sebastian Bergmann (RETIRED) gentoo-dev 2005-03-15 09:07:50 UTC
Fixed in php5-sapi-r1.eclass.