Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830468 - media-sound/strawberry: unneeded dependencies
Summary: media-sound/strawberry: unneeded dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-02 21:12 UTC by Jonas Kvinge
Modified: 2022-01-03 17:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Kvinge 2022-01-02 21:12:35 UTC
I opened a pull request here: https://github.com/gentoo/gentoo/pull/23635
But the bot complained about no issue.

The homepage and git URL's point to the old ones that might stop working any time, they should be updated to the new ones:
Homepage: https://www.strawberrymusicplayer.org/
Git: https://github.com/strawberrymusicplayer/strawberry

The package have depends on quite few libraries that aren't required, some have never been required by strawberry and has nothing to do with strawberry at all.

qca - This is a Qt cryptographic library, strawberry does not use this, and have depended on it.
libmygpo - Strawberry does not use this, and have never depended on it.
glu - There were a couple of glu included headers in the very early versions (<= 0.3), these are long gone, there is no need for this anymore.
qtopengl - This dependency was removed in version 0.4.2. Strawberry does not need this Qt module.
libxml2 - Strawberry uses the Qt Core XML API and does not need this.
qtxml - This is the old deprecated Qt XML module. Dependency was removed in version 0.5.1, (only liblastfm used it previously), Strawberry doesn't use the old liblastfm anymore and uses the new XML functionality found in Qt Core for everything.

I didn't address this:

gnutls, strawberry directly depends on gnutls so I'm not sure why it's not listed, but one or more of the other packages probably depends on this already since it works.
Not sure why it depends on a patched taglib 1.11.1 from 2018 when taglib 1.12 have been available for quite some time.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2022-01-03 17:55:22 UTC
commit 8388e3e3c1ddc7093150fd0772a95394de99151e
Author: Jonas Kvinge <jonas@jkvinge.net>
Date:   Sun Jan 2 21:58:56 2022

    media-sound/strawberry: Fix URLs and remove unused dependencies

    Signed-off-by: Jonas Kvinge <jonas@jkvinge.net>
    Closes: https://github.com/gentoo/gentoo/pull/23635
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>