Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829382 - Patches: media-sound/easytag-2.4.3 metadata and cddb request bugs
Summary: Patches: media-sound/easytag-2.4.3 metadata and cddb request bugs
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-17 02:53 UTC by rogge
Modified: 2021-12-17 22:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
CDDB patch (easytag-2.4.3-cddb.patch,28.22 KB, patch)
2021-12-17 02:53 UTC, rogge
Details | Diff
metainfo patch (easytag-2.4.3-metainfo.patch,824 bytes, patch)
2021-12-17 02:54 UTC, rogge
Details | Diff
Build log (emerge-log.23,155.20 KB, text/plain)
2021-12-17 02:55 UTC, rogge
Details
easytag ebuild with two new patches (easytag-2.4.3-r3.ebuild,1.82 KB, text/plain)
2021-12-17 02:56 UTC, rogge
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rogge 2021-12-17 02:53:03 UTC
Created attachment 759380 [details, diff]
CDDB patch

Hi!

I faced a cddb request problem these days. It is mentioned on the project website: https://gitlab.gnome.org/GNOME/easytag/-/issues/60
Since it's not a Gentoo related problem I'd posted the patch there as well.
However there is another (Gentoo related?) bug (https://bugs.gentoo.org/show_bug.cgi?id=751694) I'd build a second patch for that.

Greeting, rogge
Comment 1 rogge 2021-12-17 02:54:33 UTC
Created attachment 759381 [details, diff]
metainfo patch
Comment 2 rogge 2021-12-17 02:55:36 UTC
Created attachment 759382 [details]
Build log
Comment 3 rogge 2021-12-17 02:56:48 UTC
Created attachment 759383 [details]
easytag ebuild with two new patches
Comment 4 rogge 2021-12-17 03:52:43 UTC
This is what's happen in the patch:

* Kicking out all unnecessary FreeDB stuff
* Since GnuDB can handle cddb requests there is no need to deal with 'HTTP/1.0' nor fall back to http requests only
* The 'Manual Search' uses actually a hack now. The search request is going to 'www.gnudb.org' (no cgi path), but while klicking on the results (e. g. 43 Albums found → klicking on one) the further request will be cddb one. BUT 'www.gnudb.org' can't handle that. Here are one and a half problems: The cddb request needs a cgi path, which can be added easily and wont disturb the former www search request. However the cddb URL will be derived from the search request and results in 'www.gnudb.org/~cddb/cddb.cgi'. As reported this wont work. That's why the URL for the attached cddb request will derived from the first 'Automated Search' field.
* Apropos 'Manual search': the recognition pattern handling the search results is fixed.

Tested with the latest version 2.4.3-r2. The compiling process is still producing some warnings, but not due to the patch nor patch related.