Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828504 - x11-misc/dmenu-5.0 center patche(s)
Summary: x11-misc/dmenu-5.0 center patche(s)
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-12-07 10:45 UTC by korte
Modified: 2022-10-07 18:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add -c to dmenu_run to appear in the center of the screen (dmenu_run-center.patch,225 bytes, patch)
2021-12-07 10:46 UTC, korte
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description korte 2021-12-07 10:45:26 UTC
The default for dmenu is to appear in the first line on screen. There is a patch [1] for positioning the dmenu in the center of the screen. Since ALT+p in dwm starts /usr/bin/dmenu_run the patch doesn't get used. In the shell script, there is no option to add "-c".

It would be nice, if there would be a useflag e.g. "center-input" to activate [1] and my attached patch for dmenu_run.

Another option would be to offer dmenu_run and a patched dmenu_run_centerd and then the dwm package can be recompiled using dmenu_run_centered.


[1] https://tools.suckless.org/dmenu/patches/center/dmenu-center-20200111-8cd37e1.diff
Center patches overview: https://tools.suckless.org/dmenu/patches/center/


Reproducible: Always
Comment 1 korte 2021-12-07 10:46:33 UTC
Created attachment 757611 [details, diff]
add -c to dmenu_run to appear in the center of the screen
Comment 2 korte 2021-12-07 10:48:25 UTC
Other packages are using dmenu, too. I have no idea, how centering would interact with them.
Comment 3 Georgy Yakovlev archtester gentoo-dev 2022-10-07 18:42:07 UTC
please use this to patch dmenu to your liking:

https://wiki.gentoo.org/wiki//etc/portage/patches

we'd like to keep it simple and not add a useflag patches. there are too many.
simplicity of dwm/dmenu allows easy user patching, and everyone uses unique set of patches.