Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82847 - media-sound/sox ebuild cleanup
Summary: media-sound/sox ebuild cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-21 10:42 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-10 06:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch over current ebuild. (sox.patch,1.13 KB, patch)
2005-02-21 10:42 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-21 10:42:20 UTC 
The attached patch applied over current ebuild cleans up a little bit media-sound/sox ebuild, removing the dependency on madplay (it depends instead on libmad), and changing from using myconf to using directly the use_enable calls inside econf call.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-21 10:42:56 UTC 
Created attachment 51800 [details, diff]
Patch over current ebuild.
Comment 2 Kito (RETIRED) gentoo-dev 2005-02-21 12:53:23 UTC 
seems like : 
  --enable-oss-dsp

should be:
use oss && myconf="${myconf} --enable-oss-dsp"

Not all systems have/want oss
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-21 12:55:54 UTC 
I know, but it seems like it's hardcoded in current ebuild, also if I'm quite sure that some time ago it was using oss useflag, so I simply copied it over.
Comment 4 Jan Brinkmann (RETIRED) gentoo-dev 2005-03-10 06:34:12 UTC 
thanks for the effort, i've made a revision bump and commited the changes.