Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82837 - inst_plugin in nsplugins.eclass causing missing links in binary packages
Summary: inst_plugin in nsplugins.eclass causing missing links in binary packages
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-21 09:16 UTC by Rob Henderson
Modified: 2005-10-17 11:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Henderson 2005-02-21 09:16:23 UTC
The inst_plugin() function in nsplugins.eclass checks for the existance of the symlink in the plugin directory and skips the creation of the link if it already exists.  This ends up causing problems if you are building a binary package for installation on another machine because the link will be missing in the binary
package if it was already there on the host building the package.  The result is that the link will be missing on machines installed using the resulting binary package.

You can workaround the problem by removing the links before you build the package, but this is error prone.  I'm not sure what the best fix is for this but it seems to me like just removing the check for the existance of the link might do the trick.  What harm is there in installing the link on top of any that might already exist?

Reproducible: Always
Steps to Reproduce:
1. Install a package that uses inst_plugin() on machine A.
2. Update this package to a new version on machine A, building a binary package in the process (emerge -b).
3. Use this resulting binary package to install this package on machine B.

Actual Results:  
Machine B has the package installed but is missing the plugin links.

Expected Results:  
The plugin links should be included in the binary package.

Portage 2.0.51-r15 (default-linux/x86/2004.0, gcc-3.3.5,
glibc-2.3.4.20040808-r1, 2.6.10-gentoo-r6 i686)
=================================================================
System uname: 2.6.10-gentoo-r6 i686 Intel(R) Pentium(R) 4 CPU 2.80GHz
Gentoo Base System version 1.4.16
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb 11 2005, 08:34:51)]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.8.5-r3, 1.5, 1.7.9-r1, 1.6.3, 1.4_p6, 1.9.4
sys-devel/binutils:  2.15.92.0.2-r1
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.4.21-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=pentium4 -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.2/share/config
/usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown
/usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref
/usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/X11/WindowMaker /etc/X11/rstart /etc/X11/serverconfig
/etc/X11/starthere /etc/X11/sysconfig /etc/X11/twm /etc/a2ps /etc/apm /etc/gconf
/etc/gnome-vfs-2.0 /etc/gtk-2.0 /etc/hotplug /etc/hotplug.d /etc/init.d
/etc/lam-mpi /etc/nmh /etc/snort /etc/sound /etc/ssl/misc /etc/terminfo
/usr/X11R6/lib/X11/xkb /usr/kde/3.3/share/config /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sfperms"
GENTOO_MIRRORS="ftp://spout.ussg.indiana.edu/pub/array2/linux/gentoo/
ftp://mirrors.tds.net/gentoo http://www.gtlib.cc.gatech.edu/pub/gentoo
http://csociety-ftp.ecn.purdue.edu/pub/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://gentoo-install.cs.indiana.edu/gentoo-portage"
USE="x86 X alsa apache2 apm arts avi berkdb bitmap-fonts cdr crypt cups curl
emboss encode esd f77 fam flac font-server foomaticdb fortran gdbm gif gimpprint
gnome gphoto2 gpm gstreamer gtk gtk2 imagemagick imap imlib ipv6 java jpeg junit
kde ldap libg++ libwww mad mbox mikmod motif mozilla mpeg mysql ncurses nls nntp
oggvorbis opengl oss pam pdflib perl png python qt quicktime readline ruby samba
sdl slang snmp spell ssl svga tcltk tcpd tetex tiff truetype truetype-fonts
type1-fonts wmf xml xml2 xmms xprint xv zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS
Comment 1 Aron Griffis (RETIRED) gentoo-dev 2005-10-17 11:43:37 UTC
The nsplugins.eclass functions are completely different now from when this bug
was filed, and I believe the problem is fixed.  Please re-open if the problem
persists for you.