Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82744 - media-sound/alsaplayer ebuild clenanup
Summary: media-sound/alsaplayer ebuild clenanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-20 17:03 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-12 07:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch over current ebuild. (alsaplayer.patch,2.57 KB, patch)
2005-02-20 17:03 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-20 17:03:19 UTC
The attached patch applied over current ebuild cleans it up a little bit.

It adds a xosd useflag to disable forced dependency on xosd library (uses autoconf cache trick to get it).
It fixes the doc useflags, making the dependency on doxygen a buildtime dependency, not a runtime one, and also uses the autoconf cache trick to disable generation of documentation.

It changes from ` ` to $( ), also if it's not a clean way to render it in a patch.

It adds || die on make install which should be better

It adds ogg/vorbis flag separations (also if -ogg +vorbis can't be done), and allow to disable (for example) oggflac support (but this could need more work, as it doesn't allow to disable it without disable vorbis, anyway, a little better than now where you can't disable it).

It was done on an older revision of ebuild as you can see, as I forgot to submit the first change (xosd), but the only change (CPPFLAGS) shouldn't be necessary now, as /usr/X11R6 is now a link to /usr .

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-20 17:03:34 UTC
Created attachment 51728 [details, diff]
Patch over current ebuild.
Comment 2 Jan Brinkmann (RETIRED) gentoo-dev 2005-03-12 07:00:34 UTC
patch applied tp a new revision, thanks.