Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82735 - fix xfs (x font server) init script to not throw warnings with new findutils
Summary: fix xfs (x font server) init script to not throw warnings with new findutils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
: 83376 83453 87736 89714 89924 91076 95567 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-02-20 14:53 UTC by Aaron Gyes
Modified: 2005-06-10 15:19 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Gyes 2005-02-20 14:53:18 UTC
With findutils 4.2.18, running the init script fills the screen with warnings.

 * Stopping X Font Server ...                      [ ok ]
 * Scanning font directories ...
find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.

find: warning: you have specified the -maxdepth option after a non-option argument -type, but options are not positional (-maxdepth affects tests specified before it as well as those specified after it).  Please specify options before other arguments.
                                                  [ ok ]
 * Indexing font directories ...
 *   /usr/share/fonts/freefont ...


The fix is easy. Change line 37 from:
fontlist="$(find $1/ -type f -maxdepth 1 | \

to:
fontlist="$(find $1/ -maxdepth 1 -type f | \
Comment 1 André Terpstra 2005-02-22 02:10:04 UTC
Same here. Apparently the order of parameters for the "find" command is important now. Looks like a simple editing problem for /etc/init.d/xfs.
Comment 2 Ciaran McCreesh 2005-02-22 05:11:47 UTC
The order of parameters was always important. It's just that the new find tells you when it's being lax and letting you get away with things that shouldn't really work.
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-26 13:55:54 UTC
*** Bug 83376 has been marked as a duplicate of this bug. ***
Comment 4 Ivan Yosifov 2005-02-27 05:10:45 UTC
*** Bug 83453 has been marked as a duplicate of this bug. ***
Comment 5 André Terpstra 2005-03-13 11:15:38 UTC
Sorry I assumed that order wasn't important before. Apparently that's untrue. Anyway, the messages still remain.
Comment 6 Joshua Baergen (RETIRED) gentoo-dev 2005-04-02 21:08:23 UTC
*** Bug 87736 has been marked as a duplicate of this bug. ***
Comment 7 Joshua Baergen (RETIRED) gentoo-dev 2005-04-02 21:13:15 UTC
Do you mean that the messages still remain after applying Aaron's suggested fix, or the Portage copy hasn't been fixed yet?  I see that the current xfs script does not contain the suggested fix.
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-03 00:45:19 UTC
Yeah, I've got a big pile of stuff on my X todo list, and I haven't had time to sit down and work on it for a couple of weeks. Hopefully soon.
Comment 9 Joshua Baergen (RETIRED) gentoo-dev 2005-04-03 09:59:49 UTC
I can write the patch if you'd like, and I confirm that the suggested fix works on my system.  Does the xfs script originate from the xorg package?  I did a quick search through the source and I can't find it, and it installs whether or not the font-server useflag is enabled.
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-03 21:04:53 UTC
In the xorg ebuild:

        exeinto /etc/init.d
...
    if use font-server; then
        newexe ${FILES_DIR}/xfs.start xfs
        insinto /etc/conf.d
        newins ${FILES_DIR}/xfs.conf.d xfs
    fi

You'll find it in the files tarball. But no need to make the patch yourself, I can do that when I'm doing the rest of the work.
Comment 11 Joshua Baergen (RETIRED) gentoo-dev 2005-04-04 16:44:14 UTC
Alright, let me know as summer comes if you'd like me to help with that list of yours :P
Comment 12 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-14 16:41:52 UTC
Should be fixed in 6.8.2-r2.
Comment 13 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-19 16:06:52 UTC
*** Bug 89714 has been marked as a duplicate of this bug. ***
Comment 14 Donnie Berkholz (RETIRED) gentoo-dev 2005-04-21 11:59:57 UTC
*** Bug 89924 has been marked as a duplicate of this bug. ***
Comment 15 Jakub Moc (RETIRED) gentoo-dev 2005-05-01 20:13:29 UTC
*** Bug 91076 has been marked as a duplicate of this bug. ***
Comment 16 Jakub Moc (RETIRED) gentoo-dev 2005-06-09 09:31:25 UTC
*** Bug 95567 has been marked as a duplicate of this bug. ***
Comment 17 spiralvoice 2005-06-10 07:05:32 UTC
(In reply to comment #12)
> Should be fixed in 6.8.2-r2.

This package is still hard-masked, could you please also patch this
in xorg-x11-6.8.2-r1?
Comment 18 Donnie Berkholz (RETIRED) gentoo-dev 2005-06-10 08:09:27 UTC
No, stable packages are intended to not change. -r2 will be unmasked shortly.
Comment 19 Stefan de Konink 2005-06-10 10:00:27 UTC
(In reply to comment #18)
> No, stable packages are intended to not change. -r2 will be unmasked shortly.

This sounds very stupid if you have a broken stable package...
Comment 20 Ivan Yosifov 2005-06-10 10:16:54 UTC
(In reply to comment #18)
> No, stable packages are intended to not change. -r2 will be unmasked shortly.

I thought they were intended to really work. Fixing a bug in "stable branch"
should be good.
Comment 21 Donnie Berkholz (RETIRED) gentoo-dev 2005-06-10 15:19:34 UTC
And the way to fix is to provide a new ebuild, instead of changing an old one in
ways that aren't widely tested and may break it in a new way while fixing one
problem.

Plus this is a syntax warning, not a build breakage, calm down.