Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82701 - kernel-2.eclass patch for later mm's and all patchsets that modify Makefile
Summary: kernel-2.eclass patch for later mm's and all patchsets that modify Makefile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High critical
Assignee: Daniel Drake (RETIRED)
URL: http://forums.gentoo.org/viewtopic-p-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-20 09:31 UTC by Joe Kappus
Modified: 2005-02-23 17:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix for kernel-2.eclass (mm-fix.diff,797 bytes, patch)
2005-02-20 09:33 UTC, Joe Kappus
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Kappus 2005-02-20 09:31:05 UTC
Well, as shown in the URL, the ebuild fails to patch mm.  I dug around a little and found the Makefile would fail.  Found it was a little odd as the patches worked manually.  So I dug around the kernel-2 eclass a bit and found that it was unpacking the kernel, sed'ing the makefile, and THEN patching it with all the other patches like mm.  

So I made a diff that adds a new function and tells it to execute after patching.  That way the patch is already on before the sed'ing happens.

Reproducible: Always
Steps to Reproduce:
1.Make an ebuild for a mm-based patchset
2.Watch it fail to patch
Comment 1 Joe Kappus 2005-02-20 09:33:48 UTC
Created attachment 51686 [details, diff]
fix for kernel-2.eclass
Comment 2 Fabio Coatti 2005-02-22 03:08:36 UTC
The patch works for me. The problem was that a tab in 2.6.11-rc3 becomes a sigle white space, causing patch to barf and creating a .rej when applying mm patch.
I've seen this with rc3-mm1 and rc3-mm2
Comment 3 Ciaran McCreesh 2005-02-22 13:45:13 UTC
Don't do -ie in one. Always split up sed's args.
Comment 4 Daniel Drake (RETIRED) gentoo-dev 2005-02-23 17:17:46 UTC
Sorry for the delay - now in CVS. Thanks for investigating.