Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82624 - net-irc/xchat require hicolor-icon-theme
Summary: net-irc/xchat require hicolor-icon-theme
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Packages in net-irc
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-19 15:09 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-08 07:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch over current ebuild. (xchat.patch,399 bytes, patch)
2005-02-19 15:10 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-19 15:09:31 UTC
Seems like xchat complain if it's unable to find at least hicolor-icon-theme:

(xchat-2:23299): Gtk-WARNING **: Could not find the icon 'gnome-fs-home'. The 'hicolor' theme was not found either, perhaps you need to install it.
You can get a copy from: http://freedesktop.org/Software/icon-theme/releases

this turned out in a newly installed system, without gnome installed.
I think hicolor-icon-theme should be put in the profile, as Gentoo is following fd.o specs for menu (glep16), I think they should be followed also for icons. And hicolor-icon-theme is a requisite to use in the right way the fd.o specs. Or at least is should be PDEPENDed on by xorg-x11, as every wm should use it as final fallback for every icon lookup.

The attached patch adds the RDEPEND for net-irc/xchat-2.4.1.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-19 15:10:30 UTC
Created attachment 51619 [details, diff]
Patch over current ebuild.
Comment 2 Sven Wegener gentoo-dev 2005-02-19 16:12:39 UTC
x11 maintainers: comments on the PDEPEND thing?
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-19 16:30:54 UTC
Couple of points ...

1. Every wm doesn't use fd.o specs. Your citation of GLEP 16 means nothing, since you'll see on glep.gentoo.org that it's marked deferred.

2. That's a toolkit- or wm- level thing, xorg shouldn't have anything to do with it. You might have more luck sticking gtk/qt folks on here to see what they say.
Comment 4 foser (RETIRED) gentoo-dev 2005-02-20 08:18:48 UTC
this is gtk and a harmless warning, gtk comes with sufficient default icons to go around. hicolor is an empty placeholder theme anyway.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-20 09:24:48 UTC
As a developer, I would say that there's nothing like an "harmless warning".. at least if the code is wrote in the right way.

As for the icons, I'm not sure if gtk comes with so much icons: my gtk+ install doesn't have any png or xpm outside demo and docs directories. Maybe is the theme which comes with icons, I don't know as I'm using gtk-qt-engine so it uses KDE's icons.

About the fd.o issue, I have contacted some authors asking why they don't add fd.o desktop files to menu. Xcdroast's author told me that until we have a fully used standard he won't add it and will continue providing it as packagers can put it where they want.
The problem is that if we expect that developers add support for standards before using them, we won't go anywhere. But this report was only to try to get rid of that gtk warning. I'm not sure if it's harmless or not, but installing hicolor made the warning disappear. If it's a complete gtk warning, I think gtk should depend on hicolor. If it's a true bogus warning, I can make a patch to gtk to avoid crying about it.
Comment 6 Sven Wegener gentoo-dev 2005-03-04 14:56:12 UTC
I just tried running xchat in my chroot with only gtk+ and without any additional
theme installed and I don't receive this message. Maybe it's because you're using
gtk-qt-engine and it uses qt's icon which is missing the gnome-fs-home icon. I
don't know much about the theme stuff and I'm not using KDE at all so I really
don't know.
Comment 7 foser (RETIRED) gentoo-dev 2005-03-08 07:46:55 UTC
this is not a bug..