Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82566 - www-servers/monkeyd will always fail for a "clean" shutdown
Summary: www-servers/monkeyd will always fail for a "clean" shutdown
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-19 05:14 UTC by James Rowe
Modified: 2005-02-20 14:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
monkeyd-fix-initd-stop.patch (monkeyd-fix-initd-stop.patch,632 bytes, patch)
2005-02-19 05:16 UTC, James Rowe
Details | Diff
monkeyd-fix-initd-stop.patch (monkeyd-fix-initd-stop.patch,652 bytes, patch)
2005-02-20 14:40 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-02-19 05:14:55 UTC
The monkeyd init.d script will _always_ fail to `stop' monkeyd and ends up
running the kill section, because monkey doesn't accept a stop flag(and to
the best of my knowledge I don't believe it ever has).  The patch attached
fixes this and just kills it straight out, resulting in no more ~strange~
and incorrect failed messages when shutting down the server.

  While looking at the script I also noted that it sends cruft at the monkey
command on startup too; monkey doesn't accept a start flag(well it does
but it is doesn't use it ;).

  The patch attached fixes both of these problems.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-02-19 05:16:06 UTC
Created attachment 51588 [details, diff]
monkeyd-fix-initd-stop.patch
Comment 2 SpanKY gentoo-dev 2005-02-19 08:59:10 UTC
i dont like running `kill` ... does this work for you in the stop() func ?

start-stop-daemon --stop --quiet --pidfile ${MONKEY_PID}
Comment 3 James Rowe 2005-02-20 14:31:06 UTC
Yeah, it works fine ;)

Just out of curiousity is that a Gentoo policy or personal preference?  I'm just curious really, so ignore at will.
Comment 4 James Rowe 2005-02-20 14:40:03 UTC
Created attachment 51723 [details, diff]
monkeyd-fix-initd-stop.patch

Just an update with SpanKY's suggested method instead of calling kill directly.
Comment 5 SpanKY gentoo-dev 2005-02-20 14:46:46 UTC
no, there is no policy ... personal experience has shown running `start-stop-daemon` on pid files to be a much more robust method than executing `kill`

added to 0.9.0-r1, thanks :)