Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82565 - mail-client/elmo installs Makefiles as docs
Summary: mail-client/elmo installs Makefiles as docs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial
Assignee: Michael Kohl (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-19 05:11 UTC by James Rowe
Modified: 2005-02-21 09:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
elmo-broken-docs.patch (elmo-broken-docs.patch,491 bytes, patch)
2005-02-19 05:12 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-02-19 05:11:32 UTC
A purely cosmetic problem, but elmo installs Makefiles along with the
docs due to the wildcard in dodoc.  The patch attached fixes that.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-02-19 05:12:51 UTC
Created attachment 51587 [details, diff]
elmo-broken-docs.patch
Comment 2 Michael Kohl (RETIRED) gentoo-dev 2005-02-20 06:13:35 UTC
I've already had an unconclusive discussion about this before: if upstream considers Makefiles as docs (at least they put them in the docs folder, didn't they?), should I really change that?

Personally I don't really care...
Comment 3 James Rowe 2005-02-20 14:53:07 UTC
*Sigh*

  The Makefile is in the docs directory because upstream has chosen to use 
separate Makefiles for each subdirectory, not because it is a document.  A 
cursory glance shows that is does actually install a file from that 
subdirectory, so even with your reasoning you should perhaps be installing 
them in ${D}/usr/share/elmo not ${D}/usr/share/doc/${PF}.

  I wonder why you aren't choosing to install configure/config.status/$other_autotools_cruft as well?  It would amount to the same thing.

  With such an obvious and easy fix I don't see why installing cruft is an 
acceptable solution.  I mean even if it is about command line length it 
wouldn't take more than about 30 seconds to wildcard the directory and then 
force a remove of the useless files.

  Still it is your decision :/
Comment 4 Michael Kohl (RETIRED) gentoo-dev 2005-02-20 15:42:13 UTC
Ok, I took over maintainance of elmo because it hadn't had a maintainer at that point in time [1]. I don't really use this myself, and therefore never really bothered to check out what this Makefiles are for.

I will apply that fix tomorrow, but please stop going all "*sigh*" and "cruft" on such minor things. But sometimes when you have little time for Gentoo development, you just spend it on the packages you actually use yourself and find interesting.

[1] If anyone wants it, I'm the last who wants to keep maintaining this.
Comment 5 Michael Kohl (RETIRED) gentoo-dev 2005-02-21 09:18:57 UTC
Hi, I just submitted a new version of the ebuild which has your patch applied. In the process I also removed COPYING, because all the licenses can be found at /usr/portage/licenses.

Please note that I *didn't* revision bump the ebuild, because the few kB saved aren't worth a recompile for most of the people I guess. If you want the files to go away, just remerge the package once it hits the mirrors.

BTW: I gave up maintainership of elmo, because I'm really not interested in the package any more. This also explains my reluctance to actually look into the issue you've pointed out, which led to my rather unqualified comment I've made yesterday. Sorry for that!