Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82503 - flac-1.1.2; altivec patch needs porting
Summary: flac-1.1.2; altivec patch needs porting
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High normal
Assignee: PPC Porters
URL:
Whiteboard:
Keywords:
Depends on: 82587
Blocks:
  Show dependency tree
 
Reported: 2005-02-18 14:59 UTC by Tony Vroon (RETIRED)
Modified: 2005-02-20 16:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Vroon (RETIRED) gentoo-dev 2005-02-18 14:59:04 UTC
The patch to the altivec support that allows it to work on non-Darwin operating systems needs porting from 1.1.1 to 1.1.2. 1.1.2 is in portage, with it's ~ppc and  ~ppc64 keywords dropped.
Please port the patch and readd the keywords after testing.
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2005-02-18 15:00:03 UTC
patching file src/libFLAC/ppc/as/lpc_asm.s
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 95 (offset 1 line).
Hunk #3 succeeded at 115 (offset 1 line).
Hunk #4 succeeded at 129 (offset 1 line).
Hunk #5 succeeded at 143 (offset 1 line).
Hunk #6 succeeded at 157 (offset 1 line).
Hunk #7 succeeded at 171 (offset 1 line).
Hunk #8 succeeded at 185 (offset 1 line).
Hunk #9 succeeded at 199 (offset 1 line).
Hunk #10 succeeded at 211 (offset 1 line).
Hunk #11 succeeded at 268 (offset 1 line).
Hunk #12 succeeded at 344 (offset 1 line).
Hunk #13 succeeded at 364 (offset 1 line).
Hunk #14 succeeded at 376 (offset 1 line).
Hunk #15 succeeded at 403 (offset 1 line).
1 out of 15 hunks FAILED -- saving rejects to file src/libFLAC/ppc/as/lpc_asm.s.rej
patching file src/libFLAC/ppc/as/Makefile.am
Hunk #1 succeeded at 38 (offset 3 lines).
patching file src/libFLAC/ppc/as/Makefile.in
Hunk #1 FAILED at 488.
1 out of 1 hunk FAILED -- saving rejects to file src/libFLAC/ppc/as/Makefile.in.rej
patching file src/libFLAC/Makefile.am
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- saving rejects to file src/libFLAC/Makefile.am.rej
patching file src/libFLAC/Makefile.in
Hunk #1 FAILED at 277.
1 out of 1 hunk FAILED -- saving rejects to file src/libFLAC/Makefile.in.rej
patching file src/libFLAC/cpu.c
Hunk #1 FAILED at 41.
Hunk #2 FAILED at 118.
2 out of 2 hunks FAILED -- saving rejects to file src/libFLAC/cpu.c.rej
Comment 2 Luca Barbato gentoo-dev 2005-02-19 02:35:44 UTC
there should be a better linux support on flac-cvs (at least were discussions about improving it)
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2005-02-19 03:18:37 UTC
The directory structure in there looks new, there is an as and a gas directory for the assembly files, perhaps gas would need to be selected, but the configure system does not do so.
These patch rejects are in the as dirctory, as that's what's currently being used. Sed'ing that path into the patchfile is not enough, as you see. (And the rejected hunks are pretty large)
Comment 4 Luca Barbato gentoo-dev 2005-02-19 04:33:19 UTC
the whole patch should be dropped
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2005-02-19 04:48:25 UTC
It won't compile without, that's why the keywords were dropped. Any solution that allows you to readd the keywords is fine by me, with or without porting the patch :)
Comment 6 Luca Barbato gentoo-dev 2005-02-19 05:25:57 UTC
Found the issue: naive AM check for the assembler.
Comment 7 Luca Barbato gentoo-dev 2005-02-19 07:12:10 UTC
Fixed in cvs, please check if works enough for you. Reopen if isn't
Comment 8 Tony Vroon (RETIRED) gentoo-dev 2005-02-19 10:46:52 UTC
Sorry Luca, just got reports it that this breaks for non-PPC users with a libtool failure. Please enhance the fix so it works everywhere :)
Please see bug 82587 for the report.
Comment 9 Luca Barbato gentoo-dev 2005-02-20 15:51:05 UTC
Looks like I should patch directly the configure...
Comment 10 Luca Barbato gentoo-dev 2005-02-20 16:56:55 UTC
Workaround applied, should work now