Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82410 - adsl-setup crash and pppoe.conf get erased when username have a &
Summary: adsl-setup crash and pppoe.conf get erased when username have a &
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-17 15:12 UTC by Pierluigi Petrelli
Modified: 2005-03-07 15:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
this is a patch for adsl-setup in rp-pppo 3.5-r7 (adsl-setup.patch,1.64 KB, patch)
2005-02-17 15:14 UTC, Pierluigi Petrelli 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierluigi Petrelli 2005-02-17 15:12:42 UTC 
the adsl-setup script use sed for to elaborate text line insert by user.
& is interpreted by the script and it fails.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Pierluigi Petrelli 2005-02-17 15:14:11 UTC 
Created attachment 51480 [details, diff]
this is a patch for adsl-setup in rp-pppo 3.5-r7
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2005-03-07 15:20:03 UTC 
fixed in r8.

You've made a mistake at the last sed. It supposed to have & as separator because some ISPs have / in usernames. I've modified adsl-setup to search for an unused (as in not found in $U) separator.

tx for the contribution