adds separate userland for the Darwins. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 51402 [details, diff] Patch to add USERLAND="Darwin"
I'm pretty sure this patch will kill support on BSD. Could you please come to some agreement on how chflags will be handled? How gsed and friends will be handled? Any other issues..? Thanks :)
*bsd folks, anyword on this? This is bordering on being a blocker for us as all .a files are h0rked, thus preventing even gcc from being merged.
I've been using the above patch on fbsd for a couple of days, and it doesn't seem to have broken anything yet...
I looked again and I don't see any wrong either. ;) I misread the following from etc-update: if [ $(/usr/lib/portage/bin/portageq envvar USERLAND) = BSD ] ; then function sed() { gsed "$@"; } +elif [ $(/usr/lib/portage/bin/portageq envvar USERLAND) = Darwin -a -x /bin/gsed ]; then + function sed() { gsed "$@"; } as the added blocks replacing the original blocks. Should probably make it something like the following anyway though: -if [ $(/usr/lib/portage/bin/portageq envvar USERLAND) = BSD ] ; then +USERLAND="$(/usr/lib/portage/bin/portageq envvar USERLAND)" +if [ "$USERLAND" == "BSD" ] || [ "$USERLAND" == "Darwin" ] ; then function sed() { gsed "$@"; } That makes it consistent with the rest of the code, prevents a second call to portageq on most OS's and saves a line of code. :)
Ahh, thank you sir, less lines is always most bestest =) I did want to check that gsed exists and is executable, as some systems have GNU sed installed without the g prefix. -if [ $(/usr/lib/portage/bin/portageq envvar USERLAND) = BSD ] ; then +USERLAND="$(/usr/lib/portage/bin/portageq envvar USERLAND)" +if [ "$USERLAND" == "BSD" ] || [ "$USERLAND" == "Darwin" -a -x /bin/gsed ] ; then function sed() { gsed "$@"; }
News about it? The gsed problem should be fixed just using gsed as now sed ebuild always install gsed command. About root/wheel group... why not just use wheel group as for everything?
Well, will leave the patch in anyway. Otherwise users (few they might be) will run into problems if they upgrade portage but haven't updated sed to a version that installs gsed as well. I'm not sure what you are talking about with root/wheel but it doesn't belong on this bug anyway.
Removing bsd cc, as this is mainly darwin problems now :)
Fixed on or before 2.0.51.22-r1
Looking through the batch of bugs, I'm not sure that some of these are actually fixed in stable. Others, the requirements have possibly changed after the initial fix was committed. If you think this bug has been closed incorrectly, please reopen or ask that it be reopened.
