Bug 822951 – media-libs/libdv should not require X11 and / or SDL to build and be usable

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Jocelyn Mayer 2021-11-10 17:21:58 UTC]

=media-libs/libdv-1.0.0-r4 and =media-video/libva-utils-2.12.0 require X11 and / or SDL to build. As libdv is a CODEC and libva can be used by mesa, opencv to make computation on GPU (vaapi USE option), wether X11 is present or not, I suggest a few changes to make them usable in those conditions.
Here are some patch to ebuild and companion patches and simple checks to show that the packages are usable without X11 and SDL.

Reproducible: Always

Steps to Reproduce:
1. Select a machine without X11 and SDL (and masked)
2. Try to compile media-libs/libdv and / or media-video/libva-utils

Actual Results:  
For media-libs/libdv, media-libs/libsdl dependency cannot be found.
For media-video/libva-utils, vendor/intel/sfcsample can not compile without X11.

Expected Results:  
Merge success

[Comment 1 Jocelyn Mayer 2021-11-10 17:23:40 UTC]

Created attachment 750201 [details, diff]
Patch to =media-libs/libdv-1.0.0-r4 ebuild to make it able to build without X11 / SDL / GTK+ installed

[Comment 2 Jocelyn Mayer 2021-11-10 17:25:51 UTC]

Created attachment 750204 [details, diff]
Patch to be used by =media-libs/libdv-1.0.0-r4 ebuild previous patch to avoid autoreconf error when SDL is not present

To be used with patch ID #750201

[Comment 3 Jocelyn Mayer 2021-11-10 17:27:21 UTC]

Created attachment 750207 [details, diff]
Patch to avoid =media-video/libva-utils-2.12.0 compilation error in vendor/intel/sfcsample subdirectory

[Comment 4 Jocelyn Mayer 2021-11-10 17:28:23 UTC]

Created attachment 750210 [details, diff]
Companion patch to avoid =media-video/libva-utils-2.12.0 compilation error in vendor/intel/sfcsample subdirectory

To be used with patch ID #750207

[Comment 5 Jocelyn Mayer 2021-11-10 17:32:20 UTC]

... please notice that GTK+ can also be an issue for libdv compilation.

After applying those patch, I can check that libdv is usable, at least by ffmpeg / mplayer:
# mplayer -vc help |grep -w DV
ffdv        ffmpeg    working   FFmpeg DV  [dvvideo]
qdv         dshow     working   Sony Digital Video (DV)  [qdv.dll]
libdv       libdv     working   Raw DV (libdv)  [libdv.so.2]
mcdv        vfw       working   MainConcept DV Codec  [mcdvd_32.dll]

I can also check that vaapi is usable on this computer:
# vainfo
libva info: VA-API version 1.12.0
libva info: Trying to open /usr/lib64/va/drivers/r600_drv_video.so
libva info: Found init function __vaDriverInit_1_12
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.12 (libva 2.12.0)
vainfo: Driver version: Mesa Gallium driver 21.1.7 for AMD RS780 (DRM 2.50.0 / 5.10.61-gentoo, LLVM 12.0.1)
vainfo: Supported profile and entrypoints
      VAProfileMPEG2Simple            : VAEntrypointVLD
      VAProfileMPEG2Main              : VAEntrypointVLD
      VAProfileNone                   : VAEntrypointVideoProc

[Comment 6 Jonas Stein 2021-11-12 18:10:50 UTC]

Please open a new ticket for media-video/libva-utils. We can only handle one thing per ticket.

[Comment 7 Jocelyn Mayer 2022-10-17 07:06:53 UTC]

Sorry that I did not saw before.
Just updated #678522 https://bugs.gentoo.org/678522

[Comment 8 Sam James 2022-10-17 07:09:38 UTC]

*** This bug has been marked as a duplicate of bug 678522 ***

[Comment 9 Sam James 2022-10-17 07:10:30 UTC]

Or I guess not a dupe for libdv

[Comment 10 Sam James 2022-10-17 07:12:58 UTC]

Where possible, please attach git am-able patches from git format-patch to gentoo.git to make review easier.

[Comment 11 Jocelyn Mayer 2022-10-18 05:21:41 UTC]

(In reply to Sam James from comment #10)
> Where possible, please attach git am-able patches from git format-patch to
> gentoo.git to make review easier.

As I'm not an 'official' gentoo developer, I don't use git clone for now but a local overlay. I did not succeed using git format-patch with a remote reference repository. Would a git diff output be acceptable ?