Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82220 - kdelibs ebuild should differentiate between ispell and aspell.
Summary: kdelibs ebuild should differentiate between ispell and aspell.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-16 01:38 UTC by Simone Gotti (RETIRED)
Modified: 2005-06-07 06:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kdelibs-kspell2-plugins-configure.in.in.patch (kdelibs-kspell2-plugins-configure.in.in.patch,1.51 KB, patch)
2005-02-16 01:42 UTC, Simone Gotti (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simone Gotti (RETIRED) gentoo-dev 2005-02-16 01:38:45 UTC
While the kdelibs/kspell2/ library always compiles the ispell plugin (also if ispell isn't installed) as it doesn't need any header/library for its compilation, the aspell plugin will be compiled only if aspell is installed as it needs "/usr/include/aspell.h" and "/usr/lib/libaspell.*".

For this reason the ebuild line

spell? ( || ( app-text/aspell
              app-text/ispell ) )

isn't right as it choose between them and if ispell is installed, aspell won't be installed.

I'll suggest to add another local use flag "aspell" that will esplicity enable the aspell support.

In this way the compilation of the aspell plugin is deterministic.

DEPEND = aspell? ( app-text/aspell )

RDEPEND = spell? ( app-text/ispell)  << As it's not needed at compilation time.

Them we should also add the explit configure flags for the compilation like is done in bug #81966.

myconf="$myconf $(use_with aspell)"

I'll attach the patch that I'll commit upstream.

kde herd: any thought?
Comment 1 Simone Gotti (RETIRED) gentoo-dev 2005-02-16 01:42:37 UTC
Created attachment 51329 [details, diff]
kdelibs-kspell2-plugins-configure.in.in.patch

Needs to be commited upstream.
Comment 2 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-16 03:01:54 UTC
Two useflags for the same thing seems a bit much, what about adding the patch 
upstream and then doing something like:

if use spell && has_version app-dicts/aspell; then
  myconf="$myconf --with-aspell"
else
  myconf="$myconf --without-aspell"
fi
Comment 3 Simone Gotti (RETIRED) gentoo-dev 2005-02-16 06:16:00 UTC
I'm ok for the fact that 2 use flags are too much but I was doing this for a dependencies problem.

My idea was that the user should be aware that it can use both the spell implementations and the fact that if we make your proposed check, portage won't be aware of this dep and so a possible depclean will remove aspell and break libkspell.
Comment 4 Gregorio Guidi (RETIRED) gentoo-dev 2005-02-16 07:16:33 UTC
Portage can remove the first package of an ||-statement if it's installed?
Comment 5 Gregorio Guidi (RETIRED) gentoo-dev 2005-06-07 06:18:26 UTC
The latest kdelibs ebuild uses the check in comment #2. This should be enough 
for now...