Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82207 - wxGTK-2.X can use -fvisibility-inlines-hidden, it is #pragma implementation that is wrong
Summary: wxGTK-2.X can use -fvisibility-inlines-hidden, it is #pragma implementation t...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo wxWidgets project
URL:
Whiteboard:
Keywords:
Depends on: 89937
Blocks:
  Show dependency tree
 
Reported: 2005-02-16 00:07 UTC by Jonathan Briggs
Modified: 2005-04-29 23:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix #pragma implementation/interface lines (wxpatch,1.27 KB, patch)
2005-02-16 00:08 UTC, Jonathan Briggs
Details | Diff
wxGTK-2.6.0-pragma.patch (wxGTK-2.6.0-pragma.patch,774 bytes, patch)
2005-04-28 23:10 UTC, Ryan Hill (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Briggs 2005-02-16 00:07:42 UTC
I have been experimenting with the GCC 4 alpha and discovered that I could not build anything against the wxGTK libraries.  I tracked the problem down to the #pragma interface/implementation lines in wx/protocol/file.h and sckfile.cpp.

I think someone must have changed a filename in the past and missed this, but these pragmas use the wrong names!

A patch is attached.  I discovered after fixing the pragma problem that wxGTK seems to work fine when compiled with the visibility-inlines-hidden option (see bug 68500).  Please retest this.

Reproducible: Always
Steps to Reproduce:
Comment 1 Jonathan Briggs 2005-02-16 00:08:34 UTC
Created attachment 51324 [details, diff]
Patch to fix #pragma implementation/interface lines
Comment 2 Jonathan Briggs 2005-02-16 00:11:54 UTC
I screwed up the patch just a little.  Please remove the last bit where I added a fprintf to the destructor.
Comment 3 Bret Towe 2005-02-22 15:59:29 UTC
this patch works for me and solved a missing symbol problem i saw on linking
on another app
Comment 4 Rob Cakebread (RETIRED) gentoo-dev 2005-04-21 19:00:58 UTC
Just a heads-up:
I'll be adding 2.6.0 to portage soon and will take a look a closer look at this. I'll be modifying 2.4.2 also, so may add your patch at the same time.
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2005-04-28 23:10:04 UTC
Created attachment 57549 [details, diff]
wxGTK-2.6.0-pragma.patch

fixed the diff header and updated to 2.6.0.  testing in a bit.
Comment 6 Ryan Hill (RETIRED) gentoo-dev 2005-04-29 17:14:23 UTC
bug #90839 obsoletes this bug.
Comment 7 Rob Cakebread (RETIRED) gentoo-dev 2005-04-29 23:04:28 UTC
Will use patch in bug #90839