Bug 821391 – sys-apps/fwupd: add plugin_logitech_hidpp

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Alexey Zapparov 2021-11-03 01:40:47 UTC]

Created attachment 748125 [details]
fwupd-1.7.1.ebuild

1.7.1 contains fixes applied via patches in 1.7.0

Also, I think we should add `$(meson_use logitech plugin_logitech_hidpp)` to `local plugins` in addition of `plugin_logitech_bulkcontroller`.

[Comment 1 Sam James 2021-11-03 01:48:14 UTC]

It actually just got added! https://gitweb.gentoo.org/repo/gentoo.git/commit/sys-apps/fwupd?id=23cbe73faa41b493d74411b34ed1f32c3976d2ca

But I'll repurpose the bug for the logitech bit?

[Comment 2 Alexey Zapparov 2021-11-03 13:51:41 UTC]

Awesome!

I see that `fwupd-1.5.7-logind_plugin.patch` was removed from 1.7.1; I believe we should bring it back. Otherwise, `logind` plugin will not be compiled for those with `USE=-systemd` :D

[Comment 3 Alexey Zapparov 2021-11-03 13:56:27 UTC]

Created attachment 748254 [details]
fwupd-1.7.1-r1

Attaching r1 ebuild with:

* reintroduced elogind patch
* adding logitech_hidpp plugin

[Comment 4 Thomas Deutschmann (RETIRED) 2021-11-03 15:11:52 UTC]

Could you please elaborate the problem you are experiencing or how to reproduce? I am using fwdup and a non-systemd system and don't have a problem.

[Comment 5 Alexey Zapparov 2021-11-03 16:18:30 UTC]

Thomas Deutschmann, I don't experience any problems. :D

`logind` plugin ensures "machine does not enter a low power mode when updates are being performed". In any case I've proposed a patch to the upstream and it was merged, so it won't be needed as of the next patch release. :D

https://github.com/fwupd/fwupd/pull/3944

[Comment 6 Alexey Zapparov 2021-11-23 02:03:19 UTC]

I have opened PR: https://github.com/gentoo/gentoo/pull/23044

[Comment 7 Thomas Deutschmann (RETIRED) 2021-12-02 15:48:26 UTC]

There is no dedicated option to enable "plugin_logitech_hidpp" -- it will get build when you set USE=gusb.

[Comment 8 Alexey Zapparov 2021-12-03 02:01:27 UTC]

Awesome! Thank you!