Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 82118 - Some extra debug useless information is printed by gaimosd
Summary: Some extra debug useless information is printed by gaimosd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gaim Bugs Crew
URL:
Whiteboard:
Keywords:
: 82164 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-02-15 07:40 UTC by Manuel Sabban
Modified: 2005-02-18 10:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
It prevent from gaim, to print useless "foo" and "bar" (patch.gaimosd.nodebug,718 bytes, text/plain)
2005-02-16 05:16 UTC, Manuel Sabban
Details
It prevent from gaim, to print useless "foo" and "bar" (patch.gaimosd.nodebug,718 bytes, text/plain)
2005-02-16 05:24 UTC, Manuel Sabban
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Sabban 2005-02-15 07:40:16 UTC
Some "foo" and "bar" are printed by gaimosd.

Reproducible: Always
Steps to Reproduce:
Launch gaim from within a console and use gaimosd

Actual Results:  
Some "foo" and "bar" are printed by gaimosd.

Expected Results:  
I would prefer have nothing that appear.

Please apply this trivial patch:

diff -ruN old/gaimosd-1.0.0/display.c new/gaimosd-1.0.0/display.c
--- old/gaimosd-1.0.0/display.c 2004-09-20 08:08:44.000000000 +0200
+++ new/gaimosd-1.0.0/display.c 2005-02-15 16:32:25.349400000 +0100
@@ -65,11 +65,9 @@
 gboolean
 osd_display_cb(osd_display_t *disp)
 {
-       printf("bar 1\n");
        if (!disp)
                return FALSE;

-       printf("bar 2\n");
        if (disp->lines > -Osd_lines) {
                disp->lines--;
                XOSD_SCROLL(Osd, 1);
@@ -82,7 +80,6 @@
                return TRUE;
        }

-       printf("bar 3\n");
        XOSD_HIDE(Osd);
        XOSD_SCROLL(Osd, Osd_lines);
        Osd_current = NULL;
@@ -328,7 +325,6 @@
        XOSD_SET_COLOUR(Osd, color);
        XOSD_SET_TIMEOUT(Osd, -1);

-       printf("foo 1\n");
        for (i = 0; i < Osd_lines; i++) {
                if (!slist)
                        break;
Comment 1 Don Seiler (RETIRED) gentoo-dev 2005-02-15 13:56:49 UTC
Please attach your patch as text/plain.
Comment 2 Don Seiler (RETIRED) gentoo-dev 2005-02-15 14:53:52 UTC
*** Bug 82164 has been marked as a duplicate of this bug. ***
Comment 3 Manuel Sabban 2005-02-16 05:16:51 UTC
Created attachment 51338 [details]
It prevent from gaim, to print useless "foo" and "bar"

Sorry, I didnt see this attachment application, so here's the patch in the
right way.
Comment 4 Manuel Sabban 2005-02-16 05:24:33 UTC
Created attachment 51339 [details]
It prevent from gaim, to print useless "foo" and "bar"

Sorry, I didnt see this attachment application, so here's the patch in the
right way.
Comment 5 Don Seiler (RETIRED) gentoo-dev 2005-02-18 10:29:52 UTC
I patched v 1.0.0 in portage.  You'll have to re-emerge it to pick up the change.