Bug 82005 – gentoo-dev-sources-2.6.10-r6 has broken version of inotify

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Novikov 2005-02-14 09:00:44 UTC]

I use gamin and KDE. When I try to umount a filesystem being monitored by gamin whole system hangs. As a temporary solution I suggest disabling inotify_super_block_umount in inotify.

Reproducible: Always
Steps to Reproduce:
1. Open mounted filesystem in konqueror
2. Unmount this filesystem
Actual Results:  
System hangs

[Comment 1 Andrew Novikov 2005-02-14 09:05:07 UTC]

Created attachment 51213 [details, diff]
inotify fix

A patch that I use to make my system tolerant to umounts. It is against
linux-2.6.10-gentoo-r6.

[Comment 2 Daniel Drake (RETIRED) 2005-02-18 08:26:04 UTC]

Any chance you could test the newer version (0.19) instead?

Revert out the patch that comes in gentoo-dev-sources-2.6.10-r6:
http://dev.gentoo.org/~dsd/gentoo-dev-sources/release-10.07/dist/4800_inotify-0.17.patch

Then apply version 0.19:
http://www.kernel.org/pub/linux/kernel/people/rml/inotify/v2.6/0.19/inotify-0.19-rml-2.6.10-1.patch

Let me know where that gets you.

[Comment 3 Andrew Novikov 2005-02-21 07:19:10 UTC]

I've tried http://www.kernel.org/pub/linux/kernel/people/rml/inotify/v2.6/0.19/inotify-0.19-rml-2.6.10-2.patch recently with no luck: system hangs on umount.
BTW patches for inotify 0.19 and 0.18 have virtually no difference:
diff -u inotify-0.18-rml-2.6.10-16.patch inotify-0.19-rml-2.6.10-2.patch
--- inotify-0.18-rml-2.6.10-16.patch    2005-02-11 19:09:40.000000000 +0300
+++ inotify-0.19-rml-2.6.10-2.patch     2005-02-21 16:58:32.000000000 +0300
@@ -1004,7 +1004,7 @@
 +
 +      spin_lock(&dev->lock);
 +      watch = dev_find_wd(dev, wd);
-+      spin_unlock(&dev->lock);
++      //spin_unlock(&dev->lock);
 +      if (!watch) {
 +              ret = -EINVAL;
 +              goto out;

[Comment 4 HARGITAI Gabor 2005-03-04 11:29:54 UTC]

Maybe try the new and hot inotify 0.20
http://www.kernel.org/pub/linux/kernel/people/rml/inotify/v2.6/0.20/

[Comment 5 Andrew Novikov 2005-03-10 03:17:10 UTC]

inotify-0.20-rml-2.6.11-3 works nicely (at least for me ;) with gentoo-dev-sources-2.6.11-r2.

[Comment 6 Daniel Drake (RETIRED) 2005-03-14 09:05:53 UTC]

inotify 0.20 is now included in gentoo-dev-sources, thanks.