It's already known the problem with make install and ptabtools. This also applies to ptb.h -> /usr/include, where ptb.h is installed as a *file* ${D}/usr/include, which of course can't be merged because it collides with the directory /usr/include/. This makes it a little hard to build against libptb, since #include <ptb.h> won't work. :-) Solution: add 'dodir /usr/include' to src_install. In addition, I found some other bugs; the ptabtools.pc file was wrong, no docs were installed, and some dependencies were missing. Regarding the deps, since in the Makefile compilation of ptb2xml is dependent on the presence of libxml-2.0 and libxslt, I've made these dependent based on the xsl USE flag. Finally, I noticed that -fPIC is omitted from CFLAGS when compiling libptb-0.2.so. Since in the Makefile both the .so and the executables share the same ptb.o, the only solution I found was to inherit flag-o-matic and append-flags -fPIC. If this isn't correct/sufficient/optimal way to handle this, please let me know. I'll attach a new ebuild below containing all these changes.
Created attachment 51182 [details] ptabtools-0.3.1-r1.ebuild
Is -fPIC actually needed? If so, on which architectures? If it's not necessary, I prefer not to alter the author's Makefile. BTW, the xml + xslt dependency seems to be non-optional, so making it conditional on a USE flag doesn't make much sense. Thanks for your input.
Regarding -fPIC: see http://www.gentoo.org/proj/en/hardened/pic-internals.xml In short, all shared libraries on all platforms really should be PIC. Applications need not be, but I don't see a way of building the lib PIC and the apps not. Regarding the xsl USE flag, quoting from the Makefile: PROGS = ptb2ly ptb2ascii ptbinfo $(shell pkg-config --exists libxml-2.0 libxslt && echo ptb2xml) In other words, building ptb2xml is dependent on pkg-config finding libxml-2.0 and libxslt; if they're not found, then ptb2xml won't be built. Nothing else depends on these 2 libs, so therefore AFAICS there is room for this USE flag.
OK. One more question: why -lptb-0.2?
Ah nevermind, I see. The library gets named libptb-0.2.so. I'll talk to the author about these issues, and fix our ebuild in the meantime. Thanks.
ptabtools-0.3.1-r1 in portage. Please reopen if there are any problems.
