Bug 81902 – app-office/openoffice cleanup of installed menu entries

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2005-02-13 12:52:09 UTC]

The attached patch, applied over current OpenOffice ebuild make it install the icons and the desktop files in a fd.o compliant way (it takes the kde ones, just because kde's desktop files usually haven't the .png extension, and the hicolor structure is directly derived from kde).

This removes the need of kde and gnome useflags.

HTH, Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2005-02-13 12:52:38 UTC]

Created attachment 51148 [details, diff]
Patch over current ebuild.

[Comment 2 Diego Elio Pettenò (RETIRED) 2005-02-13 13:01:18 UTC]

Created attachment 51149 [details, diff]
Patch for openoffice-bin

This patch fixes in the same way also openoffice-bin removing the kde and gnome
useflags.

[Comment 3 Diego Elio Pettenò (RETIRED) 2005-02-13 13:33:14 UTC]

Created attachment 51152 [details, diff]
Patch for app-office/openoffice

This time using domenu

[Comment 4 Diego Elio Pettenò (RETIRED) 2005-02-13 13:33:36 UTC]

Created attachment 51153 [details, diff]
Patch for app-office/openoffice-bin

This time using domenu

[Comment 5 Andreas Proschofsky (RETIRED) 2005-03-06 03:50:21 UTC]

As much as I would like to do that: The resulting desktop-files don't show up for me in gnome, did you test them there?

[Comment 6 Sok Ann Yap 2005-03-18 11:51:15 UTC]

Do they show up after running "update-desktop-database -q /usr/share/applications"? If so, the ebuild can inherit fdo-mime and then update the desktop database during pkg_postrm().

[Comment 7 Diego Elio Pettenò (RETIRED) 2005-03-22 16:03:00 UTC]

Created attachment 54193 [details, diff]
Updated patch for app-office/openoffice-bin

Unfortunately now i have an amd64 box and I can't test app-office/openoffice.
This just fix it, seems like kde desktop file are missing Categories stuff,
this should fix it.
It also fixes the icons which are moved into hicolor structure. Probably gnome
and kde stuff could be removed entirely after that.

It also changes from using perl to using sed as it's in every system (instead
perl could be removed, in theory).
Just two notes about that, that i don't know too much to make myself go
tinkering with that: openoffice-bin is stating in his RDEPEND perl, zip and
unzip. I was thinking if perl, zip and unzip aren't using only on build stage,
in which case they should be moved out of RDEPEND. Also there's another call of
perl -pi -e, yes it should be faster, but perl is a quite heavy ebuild to have,
and not everything needs it, so having to emerge it for this isn't a good idea,
imho.

[Comment 8 Andreas Proschofsky (RETIRED) 2005-03-30 02:19:02 UTC]

I've implemented this now, thanks for your work. Also thanks to Sok Ann Yap for the pointer at the fdo-mime-stuff, simply forgot about that.