81812 – app-cdr/cdrdao ebuild cleanup

Bug 81812 - app-cdr/cdrdao ebuild cleanup

Summary: app-cdr/cdrdao ebuild cleanup

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High enhancement (vote)
Assignee:	Lars Weiler (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-02-12 17:06 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2005-03-29 16:51 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch over current ebuild. (cdrdao.patch,1.35 KB, patch) 2005-02-12 17:07 UTC, Diego Elio Pettenò (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2005-02-12 17:06:38 UTC

I've cleaned up a bit the cdrdao ebuild, using econf instead of ./configure, changing use_enable and use_with to use $() instead of ``, adding the encode use flag to make dependency on lame optional, and at the end changing the way .desktop file and icon are installed if gnome is enabled: the .desktop file in $FILESDIR is no more needed, as it's created by make_desktop_entry, which also create it more adherent to the .desktop file standard. The icon is then installed into the hicolor structure, so different icon themes can replace it with their version of the icon.

HTH, Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-02-12 17:07:10 UTC

Created attachment 51099 [details, diff]
Patch over current ebuild.

Comment 2 Lars Weiler (RETIRED) gentoo-dev

2005-03-29 16:51:06 UTC

Thanks a lot for the cleanup!  I applied it to cdrdao-1.1.9-r2.