Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 817188 - =dev-python/pythran-0.10.0 fails tests
Summary: =dev-python/pythran-0.10.0 fails tests
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL: https://dev.gentoo.org/~marecki/bugs/...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2021-10-09 09:08 UTC by Marek Szuba
Modified: 2021-10-12 11:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (einfo.txt,5.61 KB, text/plain)
2021-10-09 09:13 UTC, Marek Szuba
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2021-10-09 09:08:45 UTC
Quite a large number of test failures, see the log.
Comment 1 Marek Szuba archtester gentoo-dev 2021-10-09 09:13:26 UTC
Created attachment 744063 [details]
emerge --info
Comment 2 Marek Szuba archtester gentoo-dev 2021-10-09 09:17:27 UTC
build.log provided as a link because even when compressed and stripped to test output only it is too large for Bugzilla.
Comment 3 Marek Szuba archtester gentoo-dev 2021-10-11 19:54:50 UTC
I've just finished trying to emerge this ebuild on amd64, same test failures. No idea if it's the same problem as in Bug #802264, as the latter hasn't got a build log attached.
Comment 4 Marek Szuba archtester gentoo-dev 2021-10-11 20:40:34 UTC
The problem is that pythran test suite (or to be precise the constructor of its TestEnv class, see pythran/tests/__init__.py) adds -Werror and -Wno-absolute-value to compiler CXX flags. The latter is not valid for C++, and the former causes the presence of the latter to be treated as an error.

Removing the two from PYTHRAN_CXX_FLAGS in the aforementioned file makes the test suite pass, on amd64 anyway.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-10-12 06:28:58 UTC
Could you attach the amd64 build log?  The riscv log suggests it's actually failing because of:

/var/tmp/portage/dev-python/pythran-0.10.0/work/pythran-0.10.0/pythran/xsimd/types/xsimd_types_include.hpp:85:24: error: #warning "No SIMD instructions set detected, please enable SIMD instructions or activate the fallback mode. (e.g. for x86 -march=native or for ARM -mfpu=neon)" [-Werror=cpp]
   85 |                       #warning "No SIMD instructions set detected, please enable SIMD instructions or activate the fallback mode. (e.g. for x86 -march=native or for ARM -mfpu=neon)"
      |                        ^~~~~~~
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-10-12 06:29:38 UTC
(the failing amd64 log, to be more precise)
Comment 7 Marek Szuba archtester gentoo-dev 2021-10-12 11:01:54 UTC
Will have to reproduce the amd64 build log but at least some of the errors in it are the same as on riscv - i.e. g++ invocation fails with exit code 1. Conversely, having applied the aforementioned change on riscv has fixed at least some (I expect the full test run to conclude some time tomorrow, it's VERY slow on my system) of the previously observed test failures.

As for the xsimd error you have quoted, pythran ebuilds should probably set -DXSIMD_ENABLE_FALLBACK -DXSIMD_SKIP_ON_WERROR - the former to enable fallback code on systems with no SSE3, AVX or Neon, the latter to suppress the compiler warning (escalated to an error by -Werror) appearing on such systems regardless of whether fallback mode has been enabled or not. On the other hand, perhaps we should only set the former and ditch -Werror from the test suite - according to the documentation Pythran does not use xsimd unless explicitly requested by setting -DHAVE_SIMD on its command line, and if I see correctly none of the tests actually use this feature (the only mention of SIMD in pythran/tests/ is in the context of OpenMP).