Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 81242 - x11-libs/gtkDPS-0.3.4 build fails
Summary: x11-libs/gtkDPS-0.3.4 build fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 All
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-08 08:32 UTC by Sebastian Spaeth
Modified: 2005-12-04 11:35 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix this ebuild (gtkDPS-0.3.4.ebuild.diff,327 bytes, patch)
2005-04-09 19:07 UTC, Jay Knight
Details | Diff
Fix directly in aclocal.m4 (gtkDPS.patch,2.64 KB, patch)
2005-04-17 07:58 UTC, Malte Starostik
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Spaeth 2005-02-08 08:32:22 UTC
Build stops here:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I -DLOCALEDIR=\"/usr/share/locale\" -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include -march=k8 -O2 -pipe -Wall -c  -fPIC -DPIC gtkDPSwidget.c -o .libs/gtkDPSwidget.logtkDPSwidget.c: In function `gtk_dps_init':
gtkDPSwidget.c:49: error: `LOCALEDIR' undeclared (first use in this function)

I see the -DLOCALEDIR in the gcc call, but somehow it doesn't get used. This is on amd64 BTW, but I don't know if that makes a difference.


-------------------
Portage 2.0.51-r15 (default-linux/amd64/2005.0, gcc-3.4.3, glibc-2.3.4.20041102-r0, 2.6.11-rc2 x86_64)
=================================================================
System uname: 2.6.11-rc2 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.6.9
Python:              dev-lang/python-2.3.4-r1 [2.3.4 (#1, Feb  8 2005, 10:58:59)]
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.4-r1
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.9.4, 1.8.5-r3, 1.7.9-r1, 1.6.3, 1.4_p6, 1.5
sys-devel/binutils:  2.15.92.0.2-r2
sys-devel/libtool:   1.5.10-r4
virtual/os-headers:  2.6.8.1-r4
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.3/env /usr/kde/3.3/share/config /usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=x86-64 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distlocks sandbox sandox userpriv"
GENTOO_MIRRORS="ftp://sunsite.cnlab-switch.ch/mirror/gentoo http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="de_CH.UTF-8"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 X acpi alsa avi berkdb bitmap-fonts bonobo cdr crypt cups f77 fam fortran gdbm gif gimpprint gnome gphoto2 gstreamer gtk gtk2 gtkhtml guile hbci imagemagick imlib java jp2 jpeg junit leim libwww lzw lzw-tiff mad mozilla ncurses nls nomotif nptl nptlonly offensive oggvorbis opengl pam perl png python readline rtc scanner slang smartcard speex spell ssl tcpd tetex truetype truetype-fonts type1-fonts usb userlocales wmf xml xml2 xmms xpm xprint xrandr xv zlib video_cards_radeon"
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS
Comment 1 Sebastian Spaeth 2005-02-08 08:35:07 UTC
P.S. Could it be because of this empty -I in the gcc call? So -DXXX would be parsed as option to -I? weird

-I.. -I -DLOCALEDIR ....
Comment 2 Sebastian Spaeth 2005-02-08 08:41:24 UTC
Yes, that is it. In /var/tmp/portage/gtkDPS-0.3.4/work/gtkDPS-0.3.4/gtkDPS/Makefile
there is the line
DPSFLAGS= -I
 If I remove the -I and do make it compiles just fine. I don't know configure magic. How do you prevent configure from adding that superfluous -I?

Thanks for helping here...
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2005-02-13 17:12:30 UTC
spyderous: please add metadata.
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-13 17:57:56 UTC
Not mine. I just committed because dgs installed stuff over xorg-x11, so I had to change everything dgs depped on.

donnie@supernova /usr/local/share/gentoo-x86/x11-base/xorg-x11 $ ewho gtkDPS
CVS log says:
gtkDPS-0.3.3-r1.ebuild: azarah
gtkDPS-0.3.4.ebuild: mholzer
Comment 5 Philipp Kern 2005-02-15 11:27:26 UTC
Some investigation brings up that configure does not detect the DPS includes (or other DPS pathes -- I didn't check this) properly. The issues are the checks done within aclocal.m4.

When passing it manually to configure it compiles fine. This shouldn't be much of a problem as the path should be static anyway.

    ./configure --prefix=/usr --host=${CHOST} \
        --with-x --with-dps --with-dps-includes=/usr/include/DPS $myconf || die

Regards,
Philipp Kern
Comment 6 Federico Felguer 2005-03-20 12:13:54 UTC
in gtkDPS/gtkDPSwidget.c line 49
LOCALEDIR is undefined...
Comment 7 dusdus 2005-03-21 00:58:14 UTC
Same problem here, also amd64 btw. 
Comment 8 Raimondo Giammanco 2005-03-21 01:46:40 UTC
Come on guys, 

Philipp Kern  already gave the answer, edit the ebuild and in the 
src_compile section just add --with-dps-includes=/usr/include/DPS after
--with-dps.

next 

ebuild /usr/portage/x11-libs/gtkDPS/gtkDPS-0.3.4.ebuild digest && emerge gtkDPS 

Or you can add the modified ebuild to your overlay. 

This on i386

Comment 9 Kevin 2005-03-24 08:06:24 UTC
This also solves the problem on ppc.
Comment 10 david somers 2005-03-29 23:21:04 UTC
Yeah... I just hit this problem too.

So on Feb 15 (comment #5),  Philipp Kern gives the solution (many thanks!).

Its now March 30, and gtkDPS-0.3.4 is still marked as *stable* despite having this bug... and a patched eBuild isn't in portage!

Call me crazy, but when a bug like this is found, why doesn't somebody remove the stable flag and put a new eBuild with the patch into portage? We're talking about modifying only one darn line.

<rant>
Sorry if the above offends (I know the gentoo developers take *any* criticism really badly), but I am in the middle of doing an uppdate to my world... normally this goes just fine, but I've encountered too many cases where the eBuilds or the procees needs some manual tweaking because simple bug fixes like this haven't made it into portage.
</rant>
Comment 11 Jay Knight 2005-04-09 19:07:12 UTC
Created attachment 55827 [details, diff]
Patch to fix this ebuild

Maybe a patch that fixes the problem will help...  Attached.
Comment 12 Malte Starostik 2005-04-17 07:58:52 UTC
Created attachment 56518 [details, diff]
Fix directly in aclocal.m4

This one fixes the issue directly in aclocal.m4
Works For Me (TM)
Comment 13 SpanKY gentoo-dev 2005-12-04 11:35:55 UTC
this was fixed a while ago