Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 810916 - sys-apps/pkgcore: unpack creates file in same directory as archive (was: net-im/signal-desktop-bin: dodoc is called on non-existing path)
Summary: sys-apps/pkgcore: unpack creates file in same directory as archive (was: net-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-29 10:29 UTC by Benedikt Reinartz
Modified: 2021-08-31 12:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benedikt Reinartz 2021-08-29 10:29:47 UTC
When running `unpack` on the changelog.gz, the file will be written to the same directory. That means the call to dodoc afterwards can not pick it up.

One could either fix the location in the dodoc call or just run dodoc directly against the packed .gz file.

While portage seems to ignore the missing file, pkgcore will fail in the install phase.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-08-29 11:19:17 UTC
Portage does not ignore it, the file is there in ${S}

Looks like a pkgcore bug rather than ebuild bug, PMS states:

   For compressed files, creates the target file in the current directory,

And not "same directory where the archive is"
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-08-29 12:29:32 UTC
I've just pushed a fix and confirmed that signal-desktop-bin installs fine.  Could you try pkgcore-9999 to confirm that it works on your end too?  Also presuming you're using it more actively than I do, could you test it a bit before I make a new release?
Comment 3 Ionen Wolkens gentoo-dev 2021-08-29 12:48:18 UTC
Looks fine on my end, albeit I'm not much of a pmerge user and so the requested feedback would be nice.
Comment 4 Benedikt Reinartz 2021-08-31 09:36:46 UTC
@Michał, that fixes the issue. I wasn't aware that pkgcore implemented the functions completely separately.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-08-31 12:12:29 UTC
Cool.  I'm planning to make next pkgcore release along with @PROVIDES support, so in the next few days at most.