Bug 810315 – dev-db/mongodb-5.0.2 - gcc11 fix not needed anymore

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Toei Rei 2021-08-25 10:59:47 UTC]

The gcc11.patch does not apply: src/mongo/db/exec/plan_stats.h already includes <optional>.

Dropping the patch allows me to build it and it works here.

Reproducible: Always

Steps to Reproduce:
1. emerge =dev-db/mongodb-5.0.2

[Comment 1 Toei Rei 2021-08-25 11:00:20 UTC]

Patch was introduced in #768339 - 4.4.8 fails on it too.

[Comment 2 Tomáš Mózes 2021-08-25 11:12:52 UTC]

I don't see it present after https://github.com/mongodb/mongo/blob/r5.0.2/src/mongo/db/exec/plan_stats.h#L35

It works here on ~amd64:
>>> Emerging (1 of 1) dev-db/mongodb-5.0.2::gentoo
 * mongodb-src-r5.0.2.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                 [ ok ]
 * Using python3.9 to build
>>> Unpacking source...
>>> Unpacking mongodb-src-r5.0.2.tar.gz to /var/tmp/portage/dev-db/mongodb-5.0.2/work
>>> Source unpacked in /var/tmp/portage/dev-db/mongodb-5.0.2/work
>>> Preparing source in /var/tmp/portage/dev-db/mongodb-5.0.2/work/mongodb-src-r5.0.2 ...
 * Applying mongodb-4.4.1-boost.patch ...                                                                                                                [ ok ]
 * Applying mongodb-4.4.1-gcc11.patch ...
patching file src/mongo/db/exec/plan_stats.h
Hunk #1 succeeded at 33 with fuzz 1.                                                                                                                     [ ok ]
 * Applying mongodb-5.0.2-fix-scons.patch ...                                                                                                            [ ok ]
 * Applying mongodb-5.0.2-no-compass.patch ...                                                                                                           [ ok ]
 * Applying mongodb-5.0.2-skip-no-exceptions.patch ...                                                                                                   [ ok ]
 * Applying mongodb-5.0.2-skip-reqs-check.patch ...                                                                                                      [ ok ]
 * Applying mongodb-5.0.2-glibc-2.34.patch ...                                                                                                           [ ok ]

[Comment 3 Toei Rei 2021-08-25 11:26:48 UTC]

as of commit 91f3738437cb53a30c3e97fc1b9defe1ee537ab8 it was still in there.

[Comment 4 Tomáš Mózes 2021-08-25 13:02:25 UTC]

Back to the basics - can you compile it? If not, please attach the failing build log.

[Comment 5 Toei Rei 2021-08-25 14:12:49 UTC]

Works great if I remove that gcc fix patch as it breaks stuff on my end.

[Comment 6 Tomáš Mózes 2021-08-25 15:07:22 UTC]

(In reply to Toei Rei from comment #5)
> Works great if I remove that gcc fix patch as it breaks stuff on my end.

Please attach the build log and $(emerge --info).

[Comment 7 Toei Rei 2021-08-25 21:51:27 UTC]

Created attachment 736043 [details]
Build log

[Comment 8 Toei Rei 2021-08-25 21:53:47 UTC]

Created attachment 736045 [details]
emerge --info

repo is my local overlay I use; mongodb ebuild with the gcc11 patch dropped works

[Comment 9 Sam James 2021-08-25 22:17:16 UTC]

(In reply to Toei Rei from comment #7)
> Created attachment 736043 [details]
> Build log

It's because you're applying your own patch:
>patching file src/mongo/db/exec/plan_stats.h
>Hunk #1 FAILED at 33.
>1 out of 1 hunk FAILED -- saving rejects to file src/mongo/db/exec>/plan_stats.h.rej
> [ !! ]
> * ERROR: dev-db/mongodb-5.0.2::gentoo failed (prepare phase):
> *   patch -p1  failed with /etc/portage/patches/dev-db/mongodb/gcc11.patch

... which is now included in the ebuild (your log shows it being applied).

[Comment 10 Toei Rei 2021-08-25 23:00:29 UTC]

omg. I totally forgot about that patch as I worked on a fix back then that I forgot; Never mind then.