Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 81004 - media-video/vlc .desktop file cleanup
Summary: media-video/vlc .desktop file cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on: 86419
Blocks:
  Show dependency tree
 
Reported: 2005-02-06 10:10 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-27 20:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch over current ebuild (vlc.patch,1.01 KB, patch)
2005-02-06 10:10 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-06 10:10:16 UTC
Currently vlc uses a .desktop file in filesdir to be added in the menu, but this file is not fd.o compliant (test it with desktop-file-validate).
I changed the ebuild to use make_desktop_entry function from eutils class, which creates the .desktop file on the fly.

To be completely fd.o compliant, I also changed the way it handles the icons. Instead of using the icon which is shipped in /usr/share/vlc, I symlinked the different icons (16x16, 32x32 and 48x48) into the hicolor structure, and then used 'vlc' as the name of the icon. This way, if some other icon theme redefine the icon for vlc, it will be used instead of the default one. (for example Pastels Nuvola already does this).

I also changed the DESCRIPTION field to something that can be used as Comment for the .desktop file. I know this is an opinable choice, I only though that repeating the name of the package is redundand, imho.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-02-06 10:10:57 UTC
Created attachment 50545 [details, diff]
Patch over current ebuild
Comment 2 Chris White (RETIRED) gentoo-dev 2005-03-27 20:40:30 UTC
All closed by bug #86419's resolving.