Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80992 - linuxwacom should use headers from current kernel
Summary: linuxwacom should use headers from current kernel
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-06 08:45 UTC by jochen
Modified: 2005-04-19 10:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2005-02-06 08:45:26 UTC
the linuxwacom ebuild should use the headers from the current kernel, because otherwise it might not use the correct API when for example the glibc was compiled against 2.4 headers while you are running a 2.6 header


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2005-02-10 14:08:06 UTC
Can you give an example of where this actually breaks something that linuxwacom uses, rather than something theoretical and lacking evidence?
Comment 2 Bryan Stine (RETIRED) gentoo-dev 2005-02-10 18:44:13 UTC
I'm not so sure this is actually a problem. Aren't there quite a few other programs that would fall into the same category?
Comment 3 jochen 2005-02-11 00:16:37 UTC
hey hey... no need to get angry.

in src/wacusb.c:USBParseData

        /* dispatch event */
        switch (pEv->type)
        {
#ifdef EV_SYN
                case EV_SYN: /* kernel 2.6 */
#endif
                case EV_MSC: /* kernel 2.4 */

...

$ grep EV_SYN /usr/include/linux/input.h
$ grep EV_SYN /usr/src/linux/include/linux/input.h
#define EV_SYN                  0x00
$

if linuxwacom is compiled against 2.4 headers, the USB driver cannot correctly parse the data anymore, because it will just ignore some input events. This results in the tablet just not working. When you run wacdump, you will get an endless list of 'Invalid arguments'.

evidence enough?
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2005-03-05 15:11:59 UTC
I think the proper solution would be to force >=linux-headers-2.6 if USE=usb.
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2005-04-19 10:46:46 UTC
Fixed in 0.6.7