Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 808426 - net-libs/nodejs-14.17.4: Too low c-ares requirement
Summary: net-libs/nodejs-14.17.4: Too low c-ares requirement
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-15 09:33 UTC by Mart Raudsepp
Modified: 2021-08-16 11:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2021-08-15 09:33:10 UTC
net-libs/nodejs-14.17.4 (and probably a couple earlier versions) fail compilation when c-ares isn't upgraded first:

../src/cares_wrap.cc: In function ‘int node::cares_wrap::{anonymous}::ParseCaaReply(node::Environment*, const unsigned char*, int, v8::Local<v8::Array>, bool)’:
../src/cares_wrap.cc:324:16: error: ‘ares_parse_caa_reply’ was not declared in this scope; did you mean ‘ares_parse_soa_reply’?
  324 |   int status = ares_parse_caa_reply(buf, len, &caa_start);
      |                ^~~~~~~~~~~~~~~~~~~~
      |                ares_parse_soa_reply
../src/cares_wrap.cc:330:66: error: invalid use of incomplete type ‘struct node::cares_wrap::{anonymous}::ParseCaaReply(node::Environment*, const unsigned char*, int, v8::Local<v8::Array>, bool)::ares_caa_reply’
  330 |   for (uint32_t i = 0; current != nullptr; ++i, current = current->next) {
      |                                                                  ^~


Given that nodejs ebuild does specify a (too low) c-ares minimum requirement, might want to fix this for cleaner upgrade paths on outdated systems.
Comment 1 Marek Szuba archtester gentoo-dev 2021-08-16 11:33:33 UTC
I'll go for "fixed" here because 12.22.5 and 14.17.5 require c-ares-1.17.2 or newer, and as soon as we've had those two stabilised all other v12 and v14 version  will be gone due to security issues.