Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 807013 - DIGESTS Files in release media contain (internal) paths
Summary: DIGESTS Files in release media contain (internal) paths
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Release Team
URL:
Whiteboard:
Keywords:
: 832731 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-08-07 15:10 UTC by Michael Mair-Keimberger (mm1ke)
Modified: 2022-02-05 17:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mair-Keimberger (mm1ke) 2021-08-07 15:10:54 UTC
Hi,

Looking at some DIGESTS files for released media (stages and isos) i see that the BLAKE2 Hashes have an full path included while the SHA512 only contain the filenames. 
I guess this is not intended and there should only be the filenames included (without the paths).
I noticed this because my download scripts (which do check the hashes) started to fail recently.
Comment 2 Matt Turner gentoo-dev 2021-08-07 20:04:30 UTC
Thanks!

That's odd. Do you know when this behavior started?
Comment 3 Joshua Kinard gentoo-dev 2021-08-07 21:38:14 UTC
(In reply to Matt Turner from comment #2)
> Thanks!
> 
> That's odd. Do you know when this behavior started?

I was just wondering about this last night after o32 stages completed on one of my build machines.  I have an archive of builds and their digests going back a few years (at least to 2017).  Give me some time later to unpack them and see how far back BLAKE2 hashes were done and included full paths.
Comment 4 Joshua Kinard gentoo-dev 2021-08-07 22:03:54 UTC
(In reply to Joshua Kinard from comment #3)
> (In reply to Matt Turner from comment #2)
> > Thanks!
> > 
> > That's odd. Do you know when this behavior started?
> 
> I was just wondering about this last night after o32 stages completed on one
> of my build machines.  I have an archive of builds and their digests going
> back a few years (at least to 2017).  Give me some time later to unpack them
> and see how far back BLAKE2 hashes were done and included full paths.

The last stage builds I did in March 2020 did not use BLAKE2 hashes, only SHA512 and Whirlpool.  The DIGESTS file only has the stage tarball filename and not a full path.  So likely this bug was introduced when BLAKE2 support was introduced and made a default.
Comment 5 Georgy Yakovlev archtester gentoo-dev 2021-08-08 01:46:48 UTC
hosts which use -9999 catalyst seem to generate correct digests (only basename without path).

afaik amd64 hosts use versioned catalyst.

maybe something went wrong backporting blake2b support to stable branch?
Comment 6 Michael Mair-Keimberger (mm1ke) 2021-08-15 16:19:07 UTC
I've checked my logfiles.
For me it seems it all startet on the 04.07.2021. The first file which had this path included was /var/tmp/catalyst/builds/default/stage3-i686-systemd-20210703T190603Z.tar.xz
FYI: My script only downloads the x86 and amd64 iso's + the stage3 images for this arches (inclusive systemd variant)
Comment 7 Joshua Kinard gentoo-dev 2022-02-05 01:51:41 UTC
*** Bug 832731 has been marked as a duplicate of this bug. ***
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2022-02-05 15:56:47 UTC
Fixed by dropping the blake2 hash (on amd64, x86, m68k, alpha, riscv).
Comment 9 Joshua Kinard gentoo-dev 2022-02-05 16:30:02 UTC
(In reply to Andreas K. Hüttel from comment #8)
> Fixed by dropping the blake2 hash (on amd64, x86, m68k, alpha, riscv).

Was this fixed directly in Catalyst, or just on the DIGESTS files on the mirrors for the listed archs?
Comment 10 Andreas K. Hüttel archtester gentoo-dev 2022-02-05 16:36:01 UTC
(In reply to Georgy Yakovlev from comment #5)
> hosts which use -9999 catalyst seem to generate correct digests (only
> basename without path).
> 
> afaik amd64 hosts use versioned catalyst.


(In reply to Joshua Kinard from comment #9)
> 
> Was this fixed directly in Catalyst, or just on the DIGESTS files on the
> mirrors for the listed archs?

By dropping blake2 from the config on the one host which uses stable catalyst.
Comment 11 Joshua Kinard gentoo-dev 2022-02-05 17:00:53 UTC
(In reply to Andreas K. Hüttel from comment #10)
> (In reply to Georgy Yakovlev from comment #5)
> > hosts which use -9999 catalyst seem to generate correct digests (only
> > basename without path).
> > 
> > afaik amd64 hosts use versioned catalyst.
> 
> 
> (In reply to Joshua Kinard from comment #9)
> > 
> > Was this fixed directly in Catalyst, or just on the DIGESTS files on the
> > mirrors for the listed archs?
> 
> By dropping blake2 from the config on the one host which uses stable
> catalyst.

Okay, so versioned/stable catalyst is still affected, then.  I'll check later for a bug against stable and follow that, and if I can't find one, open a new one so that stable will eventually get a fix.  Thanks!