Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80690 - faac 1.24 creates bad tags on MP4 files -- fixed in cvs version
Summary: faac 1.24 creates bad tags on MP4 files -- fixed in cvs version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 91230
  Show dependency tree
 
Reported: 2005-02-04 02:47 UTC by Barry Shilliday
Modified: 2006-04-25 18:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barry Shilliday 2005-02-04 02:47:23 UTC
There's a bug in faac 1.24, whereby if you create an MP4 file with track numbers that begin with a 0, the track information is lost for tracks 8 and 9.

Many programs like kaudiocreator automatically prefix a 0 to track numbers 1-9, and display this problem.


Reproducible: Always
Steps to Reproduce:
1. faac -o test.mp4 --track 08 test.wav
2.
3.

Actual Results:  
Track information is lost.

Expected Results:  
Create the tag correctly.

This is fixed in the latest CVS-based release, available here:

http://www.audiocoding.com/modules/mydownloads/singlefile.php?cid=3&lid=20
Comment 1 Johannes Ballé 2005-05-06 02:26:10 UTC
Hello!

Different problem, but same solution: For some input files, faac 1.24 seems to run into an endless loop. Considering the pattern the problem occurs in, I would say it has to do with memory initialisation. It even occurs with compiler optimisation turned completely off. However, it seems to be fixed in faac-cvs-18102004. I built the CVS version by renaming faac-1.24.ebuild to faac-18102004.ebuild. It worked out of the box.

I therefore strongly suggest to make an ebuild for the CVS version and have it tested. It seems to me that faac-cvs is indeed more stable than the "stable" version.
Comment 2 Jose A. Hernandez 2005-09-26 13:30:25 UTC
Found this solution on faac's sourceforge bug page:

"Changing the %i to %d in the 2 sscanf calls fixes the
problem and allows faac to handle properly track numbers 08
and 09.  This change is in frontend/main.c"

I did the changes, created a local ebuild (1.24.1) and compiled it.  Works like
a charm!
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-04-18 09:46:18 UTC
Sorry for being late, it should be fixed now.
Comment 4 Simon Roby 2006-04-25 18:38:21 UTC
Not fixed, since faac-1.24-r2 still applies faac-1.24-faad.patch, which removes MP4 support, making this fix completely pointless...