Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80638 - gimp-2.2.3: mmx and sse work on amd64
Summary: gimp-2.2.3: mmx and sse work on amd64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 All
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-02-03 14:45 UTC by Georgi Georgiev
Modified: 2005-02-09 17:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgi Georgiev 2005-02-03 14:45:18 UTC
Enabling sse and mmx on gimp for amd64 works OK. At least gimp-2.2 compiled and ran fine with the following patch applied:

--- /usr/portage/media-gfx/gimp/gimp-2.2.3.ebuild       2005-02-03 13:18:25.000000000 +0900
+++ /usr/portage-chutz/media-gfx/gimp/gimp-2.2.3.ebuild 2005-02-04 07:17:28.837444077 +0900
@@ -86,8 +86,10 @@
        if use hardened; then
                ewarn "hardened use flag suppressing mmx use flag"
                HARDENED_SUPPRESS_MMX="--disable-mmx"
-       else
+       elif use x86; then
                HARDENED_SUPPRESS_MMX="`use_enable mmx`"
+       elif use amd64; then
+               HARDENED_SUPPRESS_MMX="--enable-mmx"
        fi
 
        local myconf
@@ -99,6 +101,7 @@
                "${HARDENED_SUPPRESS_MMX}" \
                ${myconf} \
                `use_enable sse` \
+               `use amd64 && echo --enable-sse` \
                `use_enable altivec` \
                `use_enable doc gtk-doc` \
                `use_enable python` \
Comment 1 Marcus D. Hanwell (RETIRED) gentoo-dev 2005-02-09 06:50:37 UTC
SSE doesn't seem to work here, your patch did not seem to enable it properly when building. I got the following error when trying to enable sse and mmx on my system,

cryos ~ # emerge -v gimp
Calculating dependencies ...done!
>>> emerge (1 of 1) media-gfx/gimp-2.2.3 to /
>>> md5 src_uri ;-) gimp-2.2.3.tar.bz2
>>> md5 src_uri ;-) gimp-help-2-0.6.tar.gz
>>> Unpacking source...
>>> Unpacking gimp-2.2.3.tar.bz2 to /var/tmp/portage/gimp-2.2.3/work
>>> Unpacking gimp-help-2-0.6.tar.gz to /var/tmp/portage/gimp-2.2.3/work
 * Applying ltmain_sh-1.5.0-fix-relink.patch ...                          [ ok ]
>>> Source unpacked.
 * Patching ${S}/ltmain.sh ...
 *   Applying portage-1.4.1.patch ...
 *   Applying max_cmd_len-1.5.0.patch ...
 * Applying uClibc/libtool patches ...
QA Notice: USE Flag 'hardened' not in IUSE for media-gfx/gimp-2.2.3
 * econf: updating gimp-2.2.3/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating gimp-2.2.3/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-default-binary --with-x --enable-mmx  --enable-sse --disable-altivec --enable-gtk-doc --enable-python --enable-print --with-libpng --with-libjpeg --with-libexif --with-libtiff --without-libmng --with-aa --disable-debug
configure: WARNING: you should use --build, --host, --target
configure: WARNING: invalid host type:  --enable-sse
checking for a BSD-compatible install... /bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for x86_64-pc-linux-gnu-strip... x86_64-pc-linux-gnu-strip
checking for x86_64-pc-linux-gnu-gcc... x86_64-pc-linux-gnu-gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... yes
checking for suffix of executables...
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether x86_64-pc-linux-gnu-gcc accepts -g... yes
checking for x86_64-pc-linux-gnu-gcc option to accept ANSI C... none needed
checking for style of include used by make... GNU
checking dependency style of x86_64-pc-linux-gnu-gcc... gcc3
checking build system type... configure: error: /bin/sh ./config.sub  --enable-sse failed
Comment 2 Georgi Georgiev 2005-02-09 14:43:11 UTC
Ah, somebody put "${myconf}" in quotes, which breaks the ebuild if myconf is empty. Sorry, but not my fault. Patch works fine.

Though it's weird because http://www.gentoo.org/cgi-bin/viewcvs.cgi/*checkout*/media-gfx/gimp/gimp-2.2.3.ebuild
shows that ${myconf} has no quotes, and no revisions besides the original.
Comment 3 Marcus D. Hanwell (RETIRED) gentoo-dev 2005-02-09 17:21:05 UTC
My bad - I tested this out again and all works well. Thanks for the report, this is in CVS now.