Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 806103 - sys-kernel/gentoo-sources: Select SECCOMP options only if supported
Summary: sys-kernel/gentoo-sources: Select SECCOMP options only if supported
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: 5.13.8, 5.10.56, 4.19.201, 4.14.242, ...
Keywords: InVCS, PATCH
Depends on:
Blocks:
 
Reported: 2021-08-02 00:36 UTC by Matt Turner
Modified: 2021-08-04 13:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-Select-SECCOMP-options-only-if-supported.patch (0001-Select-SECCOMP-options-only-if-supported.patch,1.64 KB, patch)
2021-08-02 00:36 UTC, Matt Turner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2021-08-02 00:36:09 UTC
Created attachment 729531 [details, diff]
0001-Select-SECCOMP-options-only-if-supported.patch

Some architectures (e.g., alpha, sparc) do not support SECCOMP. Without
this kernel builds will show

WARNING: unmet direct dependencies detected for SECCOMP
  Depends on [n]: HAVE_ARCH_SECCOMP [=n]
  Selected by [y]:
  - GENTOO_LINUX_INIT_SYSTEMD [=y] && GENTOO_LINUX [=y] && GENTOO_LINUX_UDEV [=y]

WARNING: unmet direct dependencies detected for SECCOMP_FILTER
  Depends on [n]: HAVE_ARCH_SECCOMP_FILTER [=n] && SECCOMP [=y] && NET [=y]
  Selected by [y]:
  - GENTOO_LINUX_INIT_SYSTEMD [=y] && GENTOO_LINUX [=y] && GENTOO_LINUX_UDEV [=y]
Comment 1 Mike Pagano gentoo-dev 2021-08-02 22:38:27 UTC
Thanks for the patch.

Queued up for the next release of 5.10 and 5.13.
Comment 2 Matt Turner gentoo-dev 2021-08-02 22:47:15 UTC
Thanks!

For future reference, you can simply apply the patch with `git am file.patch`. That way it correctly sets the author in the git history.
Comment 3 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2021-08-03 03:21:16 UTC
This patch broke the current kernels
https://kernel1.amd64.dev.gentoo.org/#/builders/97/builds/4/steps/8/logs/stdio
Comment 4 Matt Turner gentoo-dev 2021-08-03 03:32:40 UTC
Oops. That would be because I left out an "if":

> select SECCOMP_FILTER HAVE_ARCH_SECCOMP_FILTER

should be

> select SECCOMP_FILTER if HAVE_ARCH_SECCOMP_FILTER

(in both locations)
Comment 5 Mike Pagano gentoo-dev 2021-08-03 12:53:06 UTC
Fixed the 'if' in all branches
Comment 6 Mike Pagano gentoo-dev 2021-08-04 13:22:21 UTC
Released in latest genpatches and included in latest gentoo-sources