Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80574 - USE=shared should not exist
Summary: USE=shared should not exist
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Highest major (vote)
Assignee: Stuart Herbert (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-03 06:37 UTC by SpanKY
Modified: 2005-02-23 04:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix to eclass/php5-sapi.eclass to finish resolution of bug (php5-sapi.eclass-sharedext.patch,5.63 KB, patch)
2005-02-22 22:17 UTC, Dani Church
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2005-02-03 06:37:13 UTC
since php seems to be the only thing that uses this, please name it 'php-shared'
or something other than 'shared'

'shared' implies devs can use it generically which is a Very Bad Thing
Comment 1 Stuart Herbert (RETIRED) gentoo-dev 2005-02-21 06:52:38 UTC
The flag has been renamed to 'sharedext'.

Best regards,
Stu
Comment 2 Dani Church 2005-02-22 22:17:53 UTC
Created attachment 51923 [details, diff]
Fix to eclass/php5-sapi.eclass to finish resolution of bug
Comment 3 Dani Church 2005-02-22 22:19:07 UTC
Comment on attachment 51923 [details, diff]
Fix to eclass/php5-sapi.eclass to finish resolution of bug

Conversion to 'sharedext' was incomplete; several changes within
php5-sapi.eclass were required, as per the attached patch. 
php5-sapi_src_install() continued to use 'shared' as its test for whether to
install modules, and that broke ebuilds with USE="shared -sharedext" because it
tried to install modules ('shared') that weren't built ('-sharedext'). 
Assumably the converse would also be true, that for a USE="-shared sharedext"
ebuild it would build the modules but not install them.

This brings up another point-- specifically, that if the 'sharedext' use flag
is given but no specific modules are selected, the ebuild will fail.  This case
may be trivial enough to ignore, though.

The patch also updates IUSE to remove the 'shared' flag and updates the calls
to enable_extension_{disable,without}, since those functions now actually use
the third argument.
Comment 4 Dani Church 2005-02-23 04:23:58 UTC
Created a new bug (bug 83055) since I can't reopen this one.  What is the usual procedure for this kind of situation?