804121 – net-misc/openssh generates warning implicit declaration of function 'fnmatch'

Bug 804121 - net-misc/openssh generates warning implicit declaration of function 'fnmatch'

Summary: net-misc/openssh generates warning implicit declaration of function 'fnmatch'

Status:	RESOLVED OBSOLETE

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	AMD64 Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2021-07-25 09:11 UTC by Gamcheong Yuen
Modified:	2022-09-08 01:51 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gamcheong Yuen 2021-07-25 09:11:27 UTC

net-misc/openssh generates warning implicit declaration of function 'fnmatch' while compiling.

Due to openssh-8.3_p1-sha2-include.patch, `-I$(srcdir)/openbsd-compat` argument is added to the compiler, which makes scp.c includes $(srcdir)/openbsd-compat/fnmatch.h instead of /usr/include/fnmatch.h.

Reproducible: Always

Steps to Reproduce:
1. emerge openssh
2.
3.
Actual Results:  
Compiled successfully, with warning: implicit declaration of function 'fnmatch' is invalid in C99 [-Wimplicit-function-declaration]

Expected Results:  
Compiled successfully without warning.

Please consider remove patch openssh-8.3_p1-sha2-include.patch

Comment 1 Gamcheong Yuen 2021-07-25 09:13:16 UTC

(In reply to Gamcheong Yuen from comment #0)
> net-misc/openssh generates warning implicit declaration of function
> 'fnmatch' while compiling.
> 
> Due to openssh-8.3_p1-sha2-include.patch, `-I$(srcdir)/openbsd-compat`
> argument is added to the compiler, which makes scp.c includes
> $(srcdir)/openbsd-compat/fnmatch.h instead of /usr/include/fnmatch.h.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. emerge openssh
> 2.
> 3.
> Actual Results:  
> Compiled successfully, with warning: implicit declaration of function
> 'fnmatch' is invalid in C99 [-Wimplicit-function-declaration]
> 
> Expected Results:  
> Compiled successfully without warning.
> 
> Please consider remove patch openssh-8.3_p1-sha2-include.patch

Or consider use another way to include sha2.h for SHA2 support.

Comment 2 Sam James archtester

2022-09-08 01:51:53 UTC

This patch is gone.